Bug 467058 - [null] GVT45: "Render all annotations in Javadoc hovers" function failed in Arabic and Hebrew
Summary: [null] GVT45: "Render all annotations in Javadoc hovers" function failed in A...
Status: ASSIGNED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: PC Windows 8
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-12 02:23 EDT by Chang Jing Xu CLA
Modified: 2022-08-20 14:40 EDT (History)
5 users (show)

See Also:


Attachments
The annotation @org.eclipse.jdt.annotation.Nullable is missing in Arabic (3.26 MB, image/bmp)
2015-05-12 02:23 EDT, Chang Jing Xu CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Jing Xu CLA 2015-05-12 02:23:47 EDT
Created attachment 253401 [details]
The annotation @org.eclipse.jdt.annotation.Nullable is missing in Arabic

Build ID: I20150429-2000
JDK: IBM jdk8

Steps to reproduce:
1. Launch Eclipse in Arabic
2. Create a Java Project 
3. Create a class (eg.TestExternalAnnotations), the code as below:

import java.util.Map;

import org.eclipse.jdt.annotation.NonNull;

public class TestExternalAnnotations {
	     int test(@NonNull Map<String, Integer> map){
		return map.get("hello");     
  	} 

}

4.  Click Windows -> Preferences
5.  Click Java -> Compiler -> Errors/Warnings 
6.  Check the option " Enable annotation-based null analysis" under Null Analysis
7.  Click Window -> Preferences
8.  Expand Java -> Installed JREs
9.  Select the installed JRE (java 1.8) and Click Edit
10. Select the "External annotations:(none)" under rt.jar and Click External annotations button
11. Click Browse... and click Create New Folder to create a folder with GVT test data
12. Select you just created folder under your project and click OK    
13. Click OK on External Annotations Location Selection, click Finish on Edit JRE panel, click OK on preferences panel
14. Press Ctrl and click get to open Declaration(Please attach the soure code which you could find on the java installation path to the project firstly )  
15. Select any type in the signature of a library method or field, and invoke Annotate - either using the context menu, or by pressing Ctrl+1. 
    Proposals will be offered for marking the selected type as @Nullable  
16. Hover get


Problem Description:
The @org.eclipse.jdt.annotation.Nullable is missing in Arabic and Hebrew.
Please help investigate.
Thanks.
Comment 1 Dani Megert CLA 2015-05-12 02:32:40 EDT
For RC1 we at least need to know why it fails.
Comment 2 Stephan Herrmann CLA 2015-05-12 06:36:21 EDT
I briefly mentioned this in bug 403917 comment 22:

> In BiDi environments we fall back to the old labels, simply because I only
> implemented the linking variant. This is somewhat in line with how the
> existing implementation also falls back to a simpler version when BiDi
> processing is required.

See methods getElementLabel() and getBindingLabel() in JavaElementLinks.

There seems to be history around bug 306752 and bug 306753.
I'll be happy to help improving this post 4.5.0.
I'm not sure about the direction, though:
- improve all linked labels to work well in BiDi environments? 
Or:
- create a link-less variant of the new binding labels.
Comment 3 Stephan Herrmann CLA 2017-05-16 12:05:27 EDT
Ran out of time for 4.7. Bulk move to 4.8.
Comment 4 Stephan Herrmann CLA 2018-08-26 09:47:24 EDT
not sure what should be done, exactly.
Comment 5 Eclipse Genie CLA 2020-08-23 10:48:44 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 6 Eclipse Genie CLA 2022-08-20 14:40:05 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.