466761 – [Graphics] Replace org.eclipse.ui.views.log gif files with png files

Bug 466761 - [Graphics] Replace org.eclipse.ui.views.log gif files with png files

Summary: [Graphics] Replace org.eclipse.ui.views.log gif files with png files

Status:	RESOLVED FIXED

Alias:	None

Product:	PDE
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.5
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.6 RC2
Assignee:	Matthias Becker
QA Contact:

URL:
Whiteboard:
Keywords:	noteworthy

Depends on:
Blocks:	468945
	Show dependency tree

Reported:	2015-05-07 13:09 EDT by Lars Vogel
Modified:	2016-09-07 06:56 EDT (History)
CC List:	4 users (show)

See Also:	Gerrit Change Git Commit Gerrit Change Git Commit

Attachments
Comparison of old ( left ) and new ( right ) (33.46 KB, image/png) 2016-09-06 03:58 EDT, Matthias Becker	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lars Vogel

2015-05-07 13:09:23 EDT

Comment 1 Lars Vogel

2015-05-07 13:10:14 EDT

Something for 4.6, I guess to late for 4.5 for Tony to provide the svg files for this project in pde.ui

Comment 2 Dani Megert

2016-05-20 10:43:43 EDT

Too late for this.

Comment 3 Eclipse Genie

2016-09-06 03:47:48 EDT

New Gerrit change created: https://git.eclipse.org/r/80446

Comment 4 Matthias Becker

2016-09-06 03:58:29 EDT

Created attachment 263980 [details]
Comparison of old ( left ) and new ( right )

The SVGs mainly already existed. So to most part of the icons was just copy-paste from other bundles. Icons I had to re-draw (e.g. expert_log and import_log) could be combined out of existing onces.

So I think this change is a no-brainer.

Comment 5 Matthias Becker

2016-09-06 04:01:25 EDT

gerrit change on images repo: https://git.eclipse.org/r/#/c/80445/

Comment 6 Eclipse Genie

2016-09-06 04:28:32 EDT

Gerrit change https://git.eclipse.org/r/80445 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=051295fd0e30a79395b713022623304bc1d3c705

Comment 7 Lars Vogel

2016-09-06 04:46:15 EDT

Thanks Matthias. Can you provide a small N&N entry for M2? Repo can be found here: https://git.eclipse.org/r/#/admin/projects/www.eclipse.org/eclipse/news

Something, like: The Error view now provides high resolution images and the icons have been updated to .png files to look good in the dark theme.

Comment 8 Matthias Becker

2016-09-06 08:17:16 EDT

I just got aware of the fact that I did only replace the gifs with pngs but did not adapt the java code / plugin-xml. So this is broken right now.
How should be proceed? Provide another change that fixes this. Or first revert and provide an updated version of my change?

Comment 9 Matthias Becker

2016-09-06 08:17:43 EDT

re-open

Comment 10 Matthias Becker

2016-09-06 09:39:23 EDT

https://git.eclipse.org/r/#/c/80475/ fixes the missing adaption in Java files and plugin.xml

Comment 11 Eclipse Genie

2016-09-06 16:50:09 EDT

New Gerrit change created: https://git.eclipse.org/r/80475

Comment 12 Eclipse Genie

2016-09-06 16:50:40 EDT

Gerrit change https://git.eclipse.org/r/80475 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=3046796ecdbb6ec5e8e8d65ff45d6adf80c39c2e

Comment 13 Matthias Becker

2016-09-07 06:56:34 EDT

Do I need to cherry-pick the fixes for this also to some maintenance branch? 
If yes: To which one?