Bug 466490 - [launchbar] duplicate entries in the launchbar
Summary: [launchbar] duplicate entries in the launchbar
Status: NEW
Alias: None
Product: CDT
Classification: Tools
Component: launchbar (show other bugs)
Version: Next   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-05 15:33 EDT by Rob Stryker CLA
Modified: 2020-09-04 15:24 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Stryker CLA 2015-05-05 15:33:43 EDT
Currently, if there exist 5 items in the list of launch objects, the launchbar middle selector will have 5 + (history-size) in the list. For example, assume we have {WebProject, MyMainClass.java, ServerLaunch, MySWTMain, index.html},  the pulldown will appear as follows:

ServerLaunch {History1}
MyMainClass.java {History2}
WebProject {History3}
--------------  (Sash)
ServerLaunch {History1}
MyMainClass.java {History2}
WebProject {History3}
MySWTMain {history4}
index.html {history5}


It's reasonable to have the three most recent history items above the sash. It is not reasonable to duplicate those same items below the sash.

Patch incoming
Comment 1 Eclipse Genie CLA 2015-05-05 16:02:29 EDT
New Gerrit change created: https://git.eclipse.org/r/47212
Comment 2 Doug Schaefer CLA 2015-05-05 16:51:00 EDT
As I mentioned on the review:

"Yeah, we debate this quite often. The sash between the most recent n and the bottom which is the complete list doesn't really make it clear that these are really two lists. But it kinda looks like a single list right now and is pretty confusing. I think we need to think on this a bit more and discuss."

I guess the question is would you miss it if it wasn't in the bottom set below the sash. I think the real challenge when we introduced this was how to make the most recent stand out. But maybe it doesn't have to. Hmm.
Comment 3 Elena Laskavaia CLA 2015-05-05 22:53:24 EDT
We can make the in bold font like in font selectors, or we can 
change background? The other option - not have sash, have MRU
and people use filter to find stuff...
We also have some space in bottom row to add some buttons, like sort...
Comment 4 Marc Khouzam CLA 2015-05-06 09:08:07 EDT
Personally, I think it would be good if the line between the top 3 entries and the rest was clearly visible.  I think that would solve the problem.

Normally, I would think not showing the 3 most recent in the bottom list would be fine, but because the bottom list is in alphabetical order (which is good), it may be confusing to not see an entry there.

If the dividing line was clear, then there would be no confusion about duplication, I think.
Comment 5 Elena Laskavaia CLA 2015-05-06 09:48:45 EDT
It is sash in standard eclipse palette. But I can make it black for example
or/and thicker.
Comment 6 Eclipse Genie CLA 2015-05-06 10:09:03 EDT
New Gerrit change created: https://git.eclipse.org/r/47310
Comment 7 Elena Laskavaia CLA 2015-05-06 10:09:55 EDT
Can somebody pull it and try on windows and mac? I tried to make it black
but its ugly as hell. Selection color is better on linux but I cannot
try other platform.
Comment 9 Doug Schaefer CLA 2015-05-07 15:58:12 EDT
Also test with the dark theme. It may be really invisible there if it's black. We have other issues with the dark theme that I'll address next week.
Comment 10 Jonah Graham CLA 2020-02-26 12:05:57 EST
(In reply to Doug Schaefer from comment #9)
> Also test with the dark theme. It may be really invisible there if it's
> black. We have other issues with the dark theme that I'll address next week.

This seems to have never been done - it has been pulled out into Bug 560561.