466488 – [launchbar] Clicking edit on launches that have no launch group, tabs, or have other errors, causes several error dialogs to pop up.

Bug 466488 - [launchbar] Clicking edit on launches that have no launch group, tabs, or have other errors, causes several error dialogs to pop up.

Summary: [launchbar] Clicking edit on launches that have no launch group, tabs, or ha...

Status:	NEW

Alias:	None

Product:	CDT
Classification:	Tools
Component:	launchbar (show other bugs)
Version:	Next
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	---
Assignee:	Project Inbox
QA Contact:	Jonah Graham

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2015-05-05 15:21 EDT by Rob Stryker
Modified:	2020-09-04 15:24 EDT (History)
CC List:	0 users

See Also:	Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Rob Stryker

2015-05-05 15:21:40 EDT

Some exotic or private launch configuration types may not have launch tabs or other UI elements. This causes all sorts of NPEs and error dialogs to be thrown up by the underlying framework, because care is not taken in checking preconditions before attempting to edit a given configuration. 

Patch forthcoming.

Comment 1 Eclipse Genie

2015-05-05 16:05:06 EDT

New Gerrit change created: https://git.eclipse.org/r/47216

Comment 2 Eclipse Genie

2015-05-07 14:29:16 EDT

Gerrit change https://git.eclipse.org/r/47216 was merged to [master].
Commit: http://git.eclipse.org/c/cdt/org.eclipse.launchbar.git/commit/?id=899208ac288fb3bd68b63a6ddd19b64978f50363

Comment 3 Rob Stryker

2015-05-07 22:36:19 EDT

I think committing this while leaving the gear image for launch descriptors that cannot be edited is incorrect. 

I'm very curious why Elena thinks this is the proper solution.