465955 – Remove useless IUndoableCommand

Bug 465955 - Remove useless IUndoableCommand

Summary: Remove useless IUndoableCommand

Status:	CLOSED FIXED

Alias:	None

Product:	Sirius
Classification:	Modeling
Component:	Diagram (show other bugs)
Version:	unspecified
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	3.1.0
Assignee:	Project Inbox
QA Contact:	Jessy Mallet

URL:
Whiteboard:
Keywords:	triaged

Depends on:
Blocks:

Reported:	2015-04-30 11:18 EDT by Esteban DUGUEPEROUX
Modified:	2015-10-16 09:09 EDT (History)
CC List:	2 users (show)

See Also:	Gerrit Change Gerrit Change Git Commit Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Esteban DUGUEPEROUX

2015-04-30 11:18:00 EDT

The use of IUndoableCommand in SiriusCommand is useless since this last is a RecordingCommand and undo/redo is managed by default. Consequently ICommandTask.undo()/redo() methods are also useless. It is better to leave support of these features to the ChangeRecorder then leave user manage it itself which is error prone.

Comment 1 Eclipse Genie

2015-04-30 11:24:53 EDT

New Gerrit change created: https://git.eclipse.org/r/46902

Comment 2 Eclipse Genie

2015-05-07 04:28:32 EDT

New Gerrit change created: https://git.eclipse.org/r/47414

Comment 3 Eclipse Genie

2015-05-07 08:55:33 EDT

Gerrit change https://git.eclipse.org/r/47414 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=4c6eb7c4c416e89b57439811e1a8fb14e12631b0

Comment 4 Esteban DUGUEPEROUX

2015-05-07 08:56:20 EDT

For Sirius 3.0 IUndoableCommand and others have been deprecated and will be removed for 3.1.

Comment 5 Eclipse Genie

2015-07-08 04:16:51 EDT

Gerrit change https://git.eclipse.org/r/46902 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0820dd70e7bd9757787d3df2bdb1965f4c010e13

Comment 6 Esteban DUGUEPEROUX

2015-07-08 04:32:07 EDT

Fixed through 0820dd70e7bd9757787d3df2bdb1965f4c010e13.

Comment 7 Jessy Mallet

2015-09-28 09:08:15 EDT

No validation: Technical issue

Comment 8 Pierre-Charles David

2015-10-16 09:09:04 EDT

Available in Sirius 3.1.0.