Bug 465953 - Variables type analysis not working as expected if the specifiers renames a variable
Summary: Variables type analysis not working as expected if the specifiers renames a v...
Status: NEW
Alias: None
Product: Sirius
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on: 465561
Blocks: 542859
  Show dependency tree
 
Reported: 2015-04-30 10:57 EDT by Cedric Brun CLA
Modified: 2018-12-17 11:25 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cedric Brun CLA 2015-04-30 10:57:14 EDT 
See comments in this patchset :

https://git.eclipse.org/r/#/c/46548/1/plugins/org.eclipse.sirius.diagram/src-core/org/eclipse/sirius/diagram/business/internal/dialect/description/DiagramInterpretedExpressionQuery.java

the variables type analysis "hardcodes" the name of the variables which means if a specifier renames a variable within the context of a Tool definition it will not benefit from the type analysis and -- probably more critical -- the validation and code assist will provide the old name in addition to the new one.

This deserves a specific ticket as we should go over all the recent work in this area once we figure out how to "get the right variable name".
Comment 1 Maxime Porhel CLA 2015-05-04 05:58:19 EDT 
Steps to reproduce: 
 . Take VSM from Bug 465561
 . Modify the variables names. 
 . the variable type analysis is KO.