Comment 1 Matthias Sohn 2015-04-28 07:32:06 EDT

thanks for fixing that :-)

Comment 2 Andrey Loskutov 2015-04-28 07:33:52 EDT

(In reply to Fabio Zadrozny from comment #0)
> Created attachment 252841 [details]
> Picture showing issue
> 
> Currently when using the dark theme (on 4.5M7) the staging view and the
> commit page are not properly styled (see picture attached).
> 
> I'll provide a patch in gerrit to fix that shortly (mostly adding some css
> to fix it).

Fabio, please make sure the fix is also for the standard theme too, not only for the dark one.

Comment 3 Eclipse Genie 2015-04-28 07:34:46 EDT

New Gerrit change created: https://git.eclipse.org/r/46663

Comment 4 Fabio Zadrozny 2015-04-28 07:37:54 EDT

(In reply to Andrey Loskutov from comment #2)
> (In reply to Fabio Zadrozny from comment #0)
> > Created attachment 252841 [details]
> > Picture showing issue
> > 
> > Currently when using the dark theme (on 4.5M7) the staging view and the
> > commit page are not properly styled (see picture attached).
> > 
> > I'll provide a patch in gerrit to fix that shortly (mostly adding some css
> > to fix it).
> 
> Fabio, please make sure the fix is also for the standard theme too, not only
> for the dark one.

Hi Andrey,

Humm, I don't quite follow that... the standard theme should be fine already right? (i.e.: it uses the default light colors, so, the issue is only in the dark theme)

If I'm missing something, can you explain it a bit more so that I follow your thoughts?

Comment 5 Fabio Zadrozny 2015-04-28 07:38:54 EDT

Created attachment 252843 [details]
Picture with the patch applied

Adding a picture which shows the results after applying the patch.

Comment 6 Andrey Loskutov 2015-04-28 07:44:37 EDT

(In reply to Fabio Zadrozny from comment #4)
> Humm, I don't quite follow that... the standard theme should be fine already
> right? (i.e.: it uses the default light colors, so, the issue is only in the
> dark theme)
> 
> If I'm missing something, can you explain it a bit more so that I follow
> your thoughts?

Without to know if there are specific code for the standard theme required I just wanted to make sure if we fix something for one theme, the another one is fixed too. So if there are no extra settings for the standard one needed, it's OK.

Comment 7 Lars Vogel 2015-04-28 08:08:49 EDT

Thanks Fabio for fixing that.

Comment 8 Fabio Zadrozny 2015-04-28 09:20:14 EDT

Created attachment 252848 [details]
Picture with the patch applied

As a note, I'm uploading a new 'after' snapshot (that one was a temporary one which was wrong -- it's almost the same, but if you look closely you'll see that other elements changed the background when they shouldn't be changed).

Comment 9 Fabio Zadrozny 2015-04-29 09:54:57 EDT

Is there someone from EGit which could take a look at this change? The dark theme looks much nicer with it ;)

Thanks.

Comment 10 Matthias Sohn 2015-04-29 11:21:19 EDT

I can review your change later today

Comment 11 Matthias Sohn 2015-04-29 16:54:29 EDT

Created attachment 252915 [details]
commit dialog and staging view on Mac

on Mac the filter box in the Commit Dialog is still white, can this be fixed ?

Comment 12 Matthias Sohn 2015-04-30 08:10:07 EDT

merged as http://git.eclipse.org/c/egit/egit.git/commit/?id=9f205d27a374f295930e4b36ed0fd988d62959d3

Comment 13 Fabio Zadrozny 2015-04-30 08:26:31 EDT

(In reply to Matthias Sohn from comment #11)
> Created attachment 252915 [details]
> commit dialog and staging view on Mac
> 
> on Mac the filter box in the Commit Dialog is still white, can this be fixed
> ?

Not sure (unfortunately I won't be able to look at that now, so, please create a new issue for that).

Comment 14 Lars Vogel 2015-05-05 14:48:20 EDT

*** Bug 448784 has been marked as a duplicate of this bug. ***

Comment 15 Lars Vogel 2015-05-05 18:58:17 EDT

See Bug 466486 for the styling of the Push dialog