Bug 465630 - [JUnit] "Next/Previous Failed Test" buttons enabled on "Show Skipped Tests Only"
Summary: [JUnit] "Next/Previous Failed Test" buttons enabled on "Show Skipped Tests Only"
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 4.5 M7   Edit
Assignee: Noopur Gupta CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-27 17:13 EDT by Markus Keller CLA
Modified: 2015-04-28 10:10 EDT (History)
4 users (show)

See Also:
markus.kell.r: review+

Attachments
Patch to disable Next/Previous buttons with "Show Skipped Tests Only" (1.22 KB, patch)
2015-04-28 08:24 EDT, Noopur Gupta CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2015-04-27 17:13:47 EDT 
When Show Skipped Tests Only (bug 298603) is enabled in the JUnit view, the "Next/Previous Failed Test" buttons don't work any more. They are enabled if the test run session had errors, and they are disabled if all non-skipped tests are green.

They at least need to be disabled when they don't work. A better solution would be to change them to "Next/Previous Skipped Test" in that case.
Comment 1 Noopur Gupta CLA 2015-04-28 08:24:33 EDT 
Created attachment 252846 [details]
Patch to disable Next/Previous buttons with "Show Skipped Tests Only"

(In reply to Markus Keller from comment #0)
> When Show Skipped Tests Only (bug 298603) is enabled in the JUnit view, the
> "Next/Previous Failed Test" buttons don't work any more. They are enabled if
> the test run session had errors, and they are disabled if all non-skipped
> tests are green.
> 
> They at least need to be disabled when they don't work. A better solution
> would be to change them to "Next/Previous Skipped Test" in that case.

Attached patch disables the "Next/Previous Failed Test" buttons when "Show Skipped Tests Only" filter is applied.

The buttons can be changed to "Next/Previous Skipped Test" buttons in a separate patch later.

Markus, please have a look.
Comment 2 Markus Keller CLA 2015-04-28 09:23:07 EDT 
Looks good, and I trust you that it works. Please commit.
Comment 3 Eclipse Genie CLA 2015-04-28 09:42:26 EDT 
New Gerrit change created: https://git.eclipse.org/r/46681
Comment 4 Noopur Gupta CLA 2015-04-28 10:10:58 EDT 
Released the patch via:
http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=80a8879beff3141dbc2da105941c631799924aea

(In reply to Noopur Gupta from comment #1)
> The buttons can be changed to "Next/Previous Skipped Test" buttons in a
> separate patch later.
Reported bug 465695.