Bug 465247 - [Infra] Diagram infra plug-in has UML dependency
Summary: [Infra] Diagram infra plug-in has UML dependency
Status: NEW
Alias: None
Product: Papyrus
Classification: Modeling
Component: Diagram (show other bugs)
Version: 1.1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-22 18:48 EDT by Christian Damus CLA
Modified: 2017-09-08 09:47 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Damus CLA 2015-04-22 18:48:23 EDT
Some time after Mars M6 [1], a dependency was introduced in the

   org.eclipse.papyrus.infra.gmfdiag.common

bundle, now requiring a bundle from the UML layer:

   org.eclipse.papyrus.uml.extensionpoints;bundle-version="1.1.0"

That seems architecturally wrong.  :-)


----
[1] to be precise, in commit f544749c737d2d08868881c4a72ef9ae7996187e for bug 463290
Comment 1 Benoit Maggi CLA 2015-04-23 02:35:42 EDT
I agree!

(But this commit didn't introduce the dependency to the uml layer)
There is an other dependency to  
 org.eclipse.papyrus.uml.tools;bundle-version="1.1.0",


There are some other infra plugins depending from uml layer (at least):
 org.eclipse.papyrus.infra.gmfdiag.dnd (org.eclipse.papyrus.uml.service.types)
 org.eclipse.papyrus.infra.gmfdiag.export (org.eclipse.papyrus.uml.tools)

(Hopefully moving to many different git repositories will avoid making such mistake again :) )
Comment 2 Camille Letavernier CLA 2015-04-23 04:10:30 EDT
The dependency is caused by Util.createTemporaryResourceSet()

I guess we'd need a similar method to create pure-EMF resource sets (in infra.emf), and another one in uml.tools which adds some UML-specific configurations

In this case, I'm not even sure we need a specific resource set. A ResourceSetImpl without any specific load option would probably do the same job

Regarding other dependencies:

- infra.gmfdiag.dnd -> uml.service.types: unused dependency. To be removed
- infra.gmfdiag.common -> uml.tools: mostly unused imports + CommandBased Interface (Which should be moved out of uml.tools). One dependency on the UML Resource because we don't have an abstraction of the "Semantic Model"
Comment 3 Camille Letavernier CLA 2015-04-23 05:13:09 EDT
Most recent issues are fixed with f5f6d51

infra.gmfdiag.common still depends on uml.tools (But unused imports have been removed)