Bug 464824 - [tern] Provide preferences for Tern
Summary: [tern] Provide preferences for Tern
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: JS Tools (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P1 enhancement (vote)
Target Milestone: 9.0   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 432940 464823
Blocks: 470316
  Show dependency tree
 
Reported: 2015-04-16 14:17 EDT by Michael Rennie CLA
Modified: 2015-06-16 17:51 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2015-04-16 14:17:29 EDT
With bug 432940 fixed, we need to provide a preference page to be able to add / remove / enable / disable Tern plugins.

I envision the page would be very similar to the current plugins page.
Comment 1 Curtis Windatt CLA 2015-05-21 15:06:12 EDT
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=428b56cb2425ff188b9f9661e34c3bb0a3b2f672

Added a page with the skeleton of the Orion plug-ins page.  Disabled by default (can be changed in SettingsContainer).
Comment 2 Curtis Windatt CLA 2015-05-21 17:19:09 EDT
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=f9612d7c2d05111b5bc8de800bada98ae4c19f72

Hooked up access to the server by storing it in Orion preferences when the worker is started.
Comment 3 Michael Rennie CLA 2015-06-04 10:17:17 EDT
Updatred the pref setting to make sure that the latest plugin info can always be shown:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e6a4fe493ecc018ee2f77e370d9f07c54cdf6f27

A few items:
1. we should add a 'version' field for each plugin. This will be especially helpful for plugins like redis, mongodb, etc, where te user will want to know what version of the lib the plugin represents

2. we should put up a message on the page when you navigate there and the JS bundle has not been loaded, saying that the bundle is not loaded and we could not show the plugins loaded in Tern as a result
Comment 4 Michael Rennie CLA 2015-06-15 11:23:51 EDT
(In reply to Michael Rennie from comment #3)

> 2. we should put up a message on the page when you navigate there and the JS
> bundle has not been loaded, saying that the bundle is not loaded and we
> could not show the plugins loaded in Tern as a result

This is a must for Orion 9.
Comment 5 Curtis Windatt CLA 2015-06-16 17:51:16 EDT
If there are no plugins in the preferences to show we display an informative message.

A number of tweaks have been done to the look and feel for 9.0.  I'm closing this bug as no more changes are planned for this release.  Additional work is covered by Bug 470316.