Bug 464802 - Check org.eclipse.jdt.launching for further references to org.eclipse.core.runtime.compatibility* bundles
Summary: Check org.eclipse.jdt.launching for further references to org.eclipse.core.ru...
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.5 RC2   Edit
Assignee: Sarika Sinha CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 394739
  Show dependency tree
 
Reported: 2015-04-16 10:18 EDT by Dani Megert CLA
Modified: 2015-05-20 07:53 EDT (History)
2 users (show)

See Also:
daniel_megert: review+

Attachments
Removed reference from saved test run configuration file (14.98 KB, patch)
2015-05-20 04:22 EDT, Sarika Sinha CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2015-04-16 10:18:51 EDT 
While starting to run our tests for Gerrit changes, we got two test failures which were caused by the missing 'org.eclipse.core.runtime.compatibility' bundle.

I replaced the deprecated code that caused the failures, but we have to investigate whether other stuff is used from the compatibility layer.
Comment 1 Dani Megert CLA 2015-04-16 10:19:50 EDT 
Sarika, we should do this for RC1, so that we can delete the compatibility layer in 4.6.
Comment 2 Dani Megert CLA 2015-04-16 10:50:50 EDT 
(In reply to Dani Megert from comment #0)
> I replaced the deprecated code that caused the failures,

Fixed with http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?id=2bf6c75a08a17ddbaac9a876567e4177431def84
Comment 3 Dani Megert CLA 2015-05-19 09:47:24 EDT 
Sarika, we have to do this during RC2, see comment 1.
Comment 4 Sarika Sinha CLA 2015-05-20 01:21:11 EDT 
There is no reference in any java file but the test launch file has an entry like this :
<stringAttribute key="selected_target_plugins" value="org.eclipse.core.runtime.compatibility.registry@default:false, 

Does the gerrit test use the same launch file to run the tests ?

/org.eclipse.jdt.debug.tests/JDT Debug Test Suite.launch
Comment 5 Dani Megert CLA 2015-05-20 04:11:15 EDT 
(In reply to Sarika Sinha from comment #4)
> There is no reference in any java file but the test launch file has an entry
> like this :
> <stringAttribute key="selected_target_plugins"
> value="org.eclipse.core.runtime.compatibility.registry@default:false, 
> 
> Does the gerrit test use the same launch file to run the tests ?
> 
> /org.eclipse.jdt.debug.tests/JDT Debug Test Suite.launch

No, Gerrit executes the org.eclipse.jdt.debug.tests.AutomatedSuite.
Comment 6 Sarika Sinha CLA 2015-05-20 04:22:05 EDT 
Created attachment 253577 [details]
Removed reference from saved test run configuration file
Comment 7 Dani Megert CLA 2015-05-20 05:23:57 EDT 
(In reply to Sarika Sinha from comment #6)
> Created attachment 253577 [details] [diff]
> Removed reference from saved test run configuration file

Submitted with http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?id=98047d2b151cb5922421fdfd06b27fed5ceba2f6
Comment 8 Sarika Sinha CLA 2015-05-20 07:53:13 EDT 
Verified that we don't use any deprecated method which will invoke Compatibility layer.