Bug 464269 - Allow specifier to choose the selected elements after a tool execution
Summary: Allow specifier to choose the selected elements after a tool execution
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 0.9   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.1.0   Edit
Assignee: Laurent Fasani CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks: 428545
  Show dependency tree
 
Reported: 2015-04-09 05:46 EDT by Laurent Redor CLA
Modified: 2015-10-16 09:11 EDT (History)
5 users (show)

See Also:

Attachments
464269Project.zip (5.23 KB, application/zip)
2015-04-10 11:59 EDT, Laurent Redor CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Redor CLA 2015-04-09 05:46:03 EDT 
Currently, after a tool execution, all new graphical elements are selected (in the creation order). The last created graphical element is the primary selection.

This behavior is not always the expected one. For example, just after a creation, the direct edit tool is available on the primary selection (the last created graphical element). If the direct edit tool must operate on the first created graphical element, the user must select the diagram and then select again the first created graphical element to direct edit.

The goal of this feature is to propose a solution to handle this problematic: allow the specifier to choose the selected elements after a tool execution.
Comment 1 Laurent Redor CLA 2015-04-10 11:59:47 EDT 
Created attachment 252301 [details]
464269Project.zip

Problematic scenarios: These scenarios use the project 464269 (in 464269Project.zip) and reveal some selection problems.

Move of a border node
---------------------
* Import the project 464269 and open "newDiagram"
* Ensure you are in manual refresh mode (preference Sirius/Automatic Refresh equals to false).
* Use the tool "InOutEdge" between A and B
--> A green out port is created on A, a blue in port is created on B and an edge is created between them. All of them are selected.
* Without modification the selection, move the blue port on B.
--> KO the green port is drag and drop on B. In this case, the specifier wants that only the edge is selected.

Direct edit of a created node
-----------------------------
* Import the project 464269 and open "newDiagram"
* Ensure you are in manual refresh mode (preference Sirius/Automatic Refresh equals to false).
* Use the tool "Create sub class with Views Creation" on B
--> A subClass is created and also the hierarchy link bewteen the subClass and B.
--> KO the direct edit is not possible on the subClass. You should first select the diagram and the select again the subClass to direct edit it. In this case, the specifier wants that only the subClass is selected.
The other tool "Create sub class with forceRefresh" does the same modification but the view is created by the refresh and not by the tool.

Partial selection of the created elements
-----------------------------------------
* Import the project 464269 and open "newDiagram"
* Ensure you are in manual refresh mode (preference Sirius/Automatic Refresh equals to false).
* Use the tool "Composite pattern With Views Creation" on diagram
--> KO the specifier wants that only the "Component" class is selected after the execution of the tool, to allow to direct edit it.
Comment 2 Eclipse Genie CLA 2015-04-21 09:57:50 EDT 
New Gerrit change created: https://git.eclipse.org/r/46181
Comment 5 Eclipse Genie CLA 2015-04-27 08:17:30 EDT 
New Gerrit change created: https://git.eclipse.org/r/46550
Comment 7 Eclipse Genie CLA 2015-06-22 12:09:41 EDT 
WARNING: this patchset contains 3640 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire
Comment 8 Eclipse Genie CLA 2015-06-30 10:47:05 EDT 
New Gerrit change created: https://git.eclipse.org/r/51109
Comment 11 Laurent Fasani CLA 2015-08-04 09:16:05 EDT 
fixed
Comment 12 Eclipse Genie CLA 2015-08-05 03:14:34 EDT 
New Gerrit change created: https://git.eclipse.org/r/53200
Comment 14 Eclipse Genie CLA 2015-08-05 05:06:40 EDT 
New Gerrit change created: https://git.eclipse.org/r/53208
Comment 15 Eclipse Genie CLA 2015-08-05 06:07:41 EDT 
New Gerrit change created: https://git.eclipse.org/r/53211
Comment 17 Florian Barbin CLA 2015-09-23 08:54:37 EDT 
Verified with 3.1.0.201509211006
Comment 18 Pierre-Charles David CLA 2015-10-16 09:11:00 EDT 
Available in Sirius 3.1.0.