Community
Participate
Working Groups
First, DAnalysisModelsUpdateTests.testDAnalysisModelsPreservationOnRepairMigrate must be updated to be relevant. The test needs to reopen the session before testing the result of DAnalysis.getModels After this test fix, the test is KO but pertinent.
New Gerrit change created: https://git.eclipse.org/r/45436
Could you provide an example with a scenario to reproduce?
In reply to comment 2: After the first commit, the test is correctly written but is KO. The aim of this ticket is to understand why it is KO and provide a fix. Hence, the scenario is to have this test OK.
Gerrit change https://git.eclipse.org/r/45436 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=62a157b3bfb9c196b41affe22d88667406807aa5
Seen with Laurent. What happened is this: the changes performed in the context of bug 456351 made DAnalysisModelsUpdateTests.testDAnalysisModelsPreservationOnRepairMigrate fail, but after analysis it failed because it was actually incorrectly written and passed earlier for wrong reasons (what it tested does not correspond to what actually happens in a running system). So Laurent's patch, merged as 62a157b3bfb9c196b41affe22d88667406807aa5 rewrites the test to actually check what it should always have checked. The rewrite reveals that the corresponding behavior was actually broken (and has been for a long time probably), so the test is currently disabled. The tested behavior is somewhat independent of the work done for bug 456351, hence this new separate ticket, whose goals is to fix the underlying issue revealed by the rewritten test (and re-enable the test once this is done).
