Bug 464025 - Scary SSH warning dialog is missing host name & IP address
Summary: Scary SSH warning dialog is missing host name & IP address
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-07 06:46 EDT by Markus Keller CLA
Modified: 2015-04-14 09:17 EDT (History)
3 users (show)

See Also:


Attachments
dialog (22.40 KB, image/png)
2015-04-07 06:46 EDT, Markus Keller CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2015-04-07 06:46:55 EDT
Created attachment 252193 [details]
dialog

org.eclipse.egit.ui (3.7.1.201503042015)

I selected all Git repositories and chose context menu > Pull.

I got a scary-looking dialog that contained the new fingerprint of an SSH host, but the dialog didn't actually say for which server this fingerprint is. The dialog needs to include the IP address and DNS name (if available) of the server in question.

After I clicked Yes (because I knew it's about [1]), I got the same dialog again. Maybe because some repos connect to Gerrit and some directly talk to git.eclipse.org? I can't tell, and that's why I'm marking this bug as major.

Dialog message starts with: "WARNING: REMOTE HOST IDENTIFICATION HAS CHANGED!"

Stacktrace:

Thread [main] (Suspended)	
	owns: RunnableLock  (id=103)	
	OS.WaitMessage() line: not available [native method]	
	Display.sleep() line: 4720	
	MessageDialog(Window).runEventLoop(Shell) line: 828	
	MessageDialog(Window).open() line: 803	
	MessageDialog.open() line: 330	
	EGitCredentialsProvider.getSingleSpecial(Shell, URIish, CredentialItem) line: 178	
	EGitCredentialsProvider.access$0(EGitCredentialsProvider, Shell, URIish, CredentialItem) line: 160	
	EGitCredentialsProvider$1.run() line: 129	
	UILockListener.doPendingWork() line: 162	
	UISynchronizer$3.run() line: 154	
	RunnableLock.run() line: 35	
	UISynchronizer(Synchronizer).runAsyncMessages(boolean) line: 135	
	Display.runAsyncMessages(boolean) line: 4147	
	Display.readAndDispatch() line: 3764	
	PartRenderingEngine$4.run() line: 1112	
	Realm.runWithDefault(Realm, Runnable) line: 337	
	PartRenderingEngine.run(MApplicationElement, IEclipseContext) line: 993	
	E4Workbench.createAndRunUI(MApplicationElement) line: 156	
	Workbench$5.run() line: 654	
	Realm.runWithDefault(Realm, Runnable) line: 337	
	Workbench.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 598	
	PlatformUI.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 150	
	IDEApplication.start(IApplicationContext) line: 138	
	EclipseAppHandle.run(Object) line: 196	
	EclipseAppLauncher.runApplication(Object) line: 134	
	EclipseAppLauncher.start(Object) line: 104	
	EclipseStarter.run(Object) line: 380	
	EclipseStarter.run(String[], Runnable) line: 235	
	NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not available [native method]	
	NativeMethodAccessorImpl.invoke(Object, Object[]) line: 62	
	DelegatingMethodAccessorImpl.invoke(Object, Object[]) line: 43	
	Method.invoke(Object, Object...) line: 483	
	Main.invokeFramework(String[], URL[]) line: 648	
	Main.basicRun(String[]) line: 603	
	Main.run(String[]) line: 1465	
	Main.main(String[]) line: 1438	

[1] https://dev.eclipse.org/mhonarc/lists/eclipse.org-committers/msg01036.html
Comment 1 Matthias Sohn CLA 2015-04-14 09:17:07 EDT
This error is thrown by com.jcraft.jsch, the error messages originates from
class com.jcraft.jsch.Session.

I added Atsuhiko on cc, AFAIK he's a maintainer of jsch

@Atsuhiko: could you improve this error message in jsch to include the IP address and DNS name (if available) of the server in question?