Bug 463831 - Delete key binding not working for existing representations.
Summary: Delete key binding not working for existing representations.
Status: NEW
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 2.0.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2015-04-02 11:47 EDT by Don Purnhagen CLA
Modified: 2015-04-14 11:49 EDT (History)
2 users (show)

See Also:

Attachments
Screen grab of context menu showing the key binding. (8.68 KB, image/png)
2015-04-02 11:47 EDT, Don Purnhagen CLA 		no flags Details
Mac menu (24.46 KB, image/png)
2015-04-08 05:19 EDT, Maxime Porhel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Purnhagen CLA 2015-04-02 11:47:43 EDT 
Created attachment 252144 [details]
Screen grab of context menu showing the key binding.

Expand the representations.aird resource in a project with existing diagrams  to show individual diagrams. Select a diagram. The diagram can be deleted with the context menu "Delete" item, but not with the displayed key binding.
Comment 1 Maxime Porhel CLA 2015-04-08 05:08:26 EDT 
It works for me with Sirius master, marsM6 on Mac. The displayed keybinding correspond to delete (but I have an icon instead of the delete label) and can be executed by typing "fn+return" (no delete/suppr key).

Also tested on Windows, Luna, Sirius 2.0.5 with the delete/suppr key.
Comment 2 Maxime Porhel CLA 2015-04-08 05:10:41 EDT 
Seems to work both for representations displayed under their semantic target in the semantic resource tree and for representations displayed in the aird resource tree.

Also tests in and out of a Modeling Project.
Comment 3 Maxime Porhel CLA 2015-04-08 05:11:35 EDT 
Don, which version of Sirius do you use ? In which Eclipse version ? On which system ?
Comment 4 Maxime Porhel CLA 2015-04-08 05:19:54 EDT 
Created attachment 252222 [details]
Mac menu
Comment 5 Don Purnhagen CLA 2015-04-08 09:51:21 EDT 
Our production environment is: 

Kepler Service Release 2
Build id: 20140224-0627
With Sirius 2.0.5.201503310523 (and previous back to 2.0.3)

We also tried with an older version of Luna for Windows with Sirius 2.0.3 and the Delete key did not work there either.

So far, we have only tested on Windows 7 and 8. Our plug-ins add a lot of additional code, but we do not make any changes to the default Eclipse key bindings. I would like to find a simple diagram example plug-in so that I can verify that it is not a side effect of some of our code.

This is not a terribly important bug to us, but just wanted to report it since I discovered it.
Comment 6 Don Purnhagen CLA 2015-04-08 12:12:49 EDT 
After further investigation, this bug ONLY affects the Project Explorer view. The Delete key binding works as advertised in the Model Explorer. It should also be noted that the Rename key binding of F2 does not work in the Project Explorer either.
Comment 7 Esteban DUGUEPEROUX CLA 2015-04-14 11:49:21 EDT 
Indeed the delete shortcut doesn't works in Project Explorer.
Perhaps because the binding between DEL shortcut and the action is done programmatically in ModelExplorerView.hookGlobalActions().
We should probably define this binding in plugin.xml