Bug 463692 - Allow multiple window trims on the same side
Summary: Allow multiple window trims on the same side
Status: REOPENED
Alias: None
Product: Efxclipse
Classification: Technology
Component: Runtime (show other bugs)
Version: 1.2.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-01 10:34 EDT by Bartlomiej Cichocki CLA
Modified: 2015-06-15 08:55 EDT (History)
3 users (show)

See Also:

Attachments
Twice ToolBar (4.89 KB, image/png)
2015-04-01 10:34 EDT, Bartlomiej Cichocki CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bartlomiej Cichocki CLA 2015-04-01 10:34:13 EDT 
Created attachment 252082 [details]
Twice ToolBar

Now isn't possible to render twice Twim window (toolbar) on the same side:

<trimBars>
      <children xsi:type="menu:ToolBar"/>
</trimBars>
<trimBars>
      <children xsi:type="menu:ToolBar"/>
</trimBars>

Second trim bar covering first.

(www.eclipse.org/forums/index.php/t/1065275/)
Comment 1 Joe Van Steen CLA 2015-06-14 19:04:38 EDT 
FYI - this works with e4 SWT. This seems to be the reason my toolbar disappeared after I converted from SWT to e(fx)clipse. I have two trimbars defined, the first is a toolbar and the second was a form of header. With SWT both show. With efx only the header (defined second) shows and the toolbar (defined first) disappears. If I change the header to invisible, do not render, then the toolbar again shows. Seeing this item in the forum made me try this specific test case to verify the cause of the difference in behavior.
Comment 2 Thomas Schindl CLA 2015-06-15 08:53:00 EDT 
The problem is that this is a major change we can't introduce at this point of 2.0 (I'm even not sure we should do it in 2.1). 

While I think the original request eg to have to lines of toolbar is a valid one, the "abuse" in comment 2 should be handled in e(fx)clipse with a "efx.window.decoration.fxml" and the newly introduced HeavyWeightTrimmedWindow (I just introduced that minutes ago!)
Comment 3 Thomas Schindl CLA 2015-06-15 08:55:18 EDT 
sorry did not meant to close this one!