Bug 46356 - [Builder] simple/qualified names list for indicting dependents should be hashed collections
Summary: [Builder] simple/qualified names list for indicting dependents should be hash...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.0 M5   Edit
Assignee: Kent Johnson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-10 12:26 EST by Philipe Mulet CLA
Modified: 2018-01-19 16:42 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philipe Mulet CLA 2003-11-10 12:26:52 EST 
Build 3.0 M4

We could use sets in the IncrementalJavaBuilder qualifiedStrings/simpleStrings) 
collections. Also there are APIs to add which answer true only if not present 
already (if using sets, this is exactly what you would want).
This is in IncrementalImageBuilder#addDependentsOf

Offending scenario is a manual rebuild of one project followed by workspace 
incremental rebuilt. Lots of names are accumulated during the indictment 
process.
Comment 1 Philipe Mulet CLA 2003-11-10 12:27:17 EST 
Should be backported to 2.1 stream when fix is available.
Comment 2 Kent Johnson CLA 2003-11-10 18:18:34 EST 
Made the changes but did not see an improvement rebuilding core.runtime 
followed by an incremental build of the rest of the workspace (full source 
Eclipse workspace).

Changed IncrementalImageBuilder and ReferenceCollection. Added StringSet.
Comment 3 David Audel CLA 2003-11-24 06:58:55 EST 
Verified.