Bug 463521 - Ctrl+G should be "Goto Line"
Summary: Ctrl+G should be "Goto Line"
Status: REOPENED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Editor (show other bugs)
Version: 7.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility, triaged
Depends on:
Blocks:
 
Reported: 2015-03-30 17:53 EDT by Mark Macdonald CLA
Modified: 2017-10-19 17:33 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2015-03-30 17:53:54 EDT
These days, many text editors use Ctrl+G for the "Goto Line" command (or some variant thereof). Among the ones I tried:
- Atom.io
- Brackets
- Notepad++
- Sublime Text
- The JS code editor built into Chrome Developer Tools

The Orion editor should provide a Ctrl+G binding for goto line as well.

It wouldn't hurt to leave Ctrl+L bound too, since Eclipse desktop users might expect it.
Comment 1 Eric Moffatt CLA 2015-06-11 09:52:19 EDT
+1, we're trying to get folks to move off of their current env and onto Orion so matching the common binding is a great idea...we might want to look for other instances where we can do this as well. 

However, the set of keys available for bindings are a valuable resource so I don't think having multiple keys bound for a single action is the way to go.
Comment 2 Mark Macdonald CLA 2015-06-11 10:04:16 EDT
OK, Ctrl+L conflicts with "Focus address bar" in some browsers anyway, so let's just remove that one.
Comment 3 Eric Moffatt CLA 2015-06-12 10:23:13 EDT
Mark, I'm closing this as WONTFIX because it's about making Ctrl-L the binding and (if I understand your comment) we're leaving the current one...

Feel free to re-open if I've misunderstood.
Comment 4 Michael Rennie CLA 2015-06-16 22:11:08 EDT
(In reply to Eric Moffatt from comment #3)
> Mark, I'm closing this as WONTFIX because it's about making Ctrl-L the
> binding and (if I understand your comment) we're leaving the current one...
> 
> Feel free to re-open if I've misunderstood.

If I'm reading this correctly, Ctrl+L should be removed and we should use Ctrl+G to avoid the browser conflict (having only one binding for Go To Line to avoid confusion). I have hit this problem before, which makes using Ctrl+L frustrating and confusing.
Comment 5 Curtis Windatt CLA 2016-12-08 11:59:55 EST
We should consider fixing this in 14.0
Comment 6 Carolyn MacLeod CLA 2017-10-16 13:56:39 EDT
a) "Goto Line" should be Ctrl+G.
b) Remove the Ctrl+L binding, because it conflicts with browser shortcut.
We should just do this.

All Windows browsers support Ctrl+L for "Focus and select address/location bar".
(Cmd+L for Mac browsers).

Keyboard users get used to being able to reorient themselves by using Ctrl+L to start at the top again. We should leave Ctrl+L unbound.

In addition to the 5 editors listed in comment 0, Ctrl+G is also used in:
- Komodo
- Codeanywhere
- VSCode
- IntelliJ
- UltraEdit
- NetBeans

It is far more common to have Ctrl+G for "Go to Line".
The only browser-based editor I am aware of (other than Orion) that uses Ctrl+L for Go To Line is ACE/Cloud9 (and there's an issue requesting that they fix it).

Let's switch the Orion editor's "Goto Line" to Ctrl+G.