Bug 463106 - Changing the BREE should create a problem marker indicating that the minor version must be increased
Summary: Changing the BREE should create a problem marker indicating that the minor ve...
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 4.5   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.7 M1   Edit
Assignee: Vikas Chandra CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks: 498182
  Show dependency tree
 
Reported: 2015-03-25 11:30 EDT by Dani Megert CLA
Modified: 2016-12-09 05:34 EST (History)
3 users (show)

See Also:

Attachments
Fix in patch format (7.29 KB, patch)
2016-07-26 07:29 EDT, Vikas Chandra CLA 		no flags Details | Diff
UI for this version management option (100.17 KB, patch)
2016-07-31 14:27 EDT, Vikas Chandra CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2015-03-25 11:30:08 EDT 
4.4.

Changing the BREE should create a problem marker indicating that the minor version must be increased.

The marker must only be created if the minor (or major) version hasn't been increased yet compared to the baseline.
Comment 1 Vikas Chandra CLA 2016-07-11 06:43:10 EDT 
In this patch, any change in BREE would cause a problem marker that would advise user to increase minor version change subject to

"The marker must only be created if the minor (or major) version hasn't been increased yet compared to the baseline."
Comment 2 Eclipse Genie CLA 2016-07-11 07:04:53 EDT 
New Gerrit change created: https://git.eclipse.org/r/77032
Comment 3 Vikas Chandra CLA 2016-07-26 07:29:59 EDT 
Created attachment 263312 [details]
Fix in patch format
Comment 4 Dani Megert CLA 2016-07-29 05:02:21 EDT 
Comment on attachment 263312 [details]
Fix in patch format

Let's use Gerrit.
Comment 5 Eclipse Genie CLA 2016-07-31 13:42:54 EDT 
New Gerrit change created: https://git.eclipse.org/r/78229
Comment 6 Vikas Chandra CLA 2016-07-31 14:19:38 EDT 
I have updated https://git.eclipse.org/r/77032.

I've added UI and updated the text for the error/warning.

ps: https://git.eclipse.org/r/78229 should be ignored.
Comment 7 Vikas Chandra CLA 2016-07-31 14:27:29 EDT 
Created attachment 263393 [details]
UI for this version management option
Comment 9 Vikas Chandra CLA 2016-07-31 14:45:26 EDT 
The changes and UI look fine to me and safe for 4.7 M1.

I'm keeping this defect open for some text changes in UI or message ( if the suggestion is better than the current one)  or both or any other corner case/s.
Comment 10 Vikas Chandra CLA 2016-08-01 02:39:11 EDT 
The build eclipse-SDK-I20160731-2000-win32-x86_64 has these changes. I tested the scenarios with Error, Warning and Ignore and it works fine.

I found 2 unrelated issues in Version Management Tab. I have opened bug 498945 bug 498947 which happen with or without this fix. I plan to take up these in early 4.7M2.
Comment 11 Vikas Chandra CLA 2016-08-03 02:46:56 EDT 
verified on eclipse-SDK-I20160731-2000-win32-x86_64