Community
Participate
Working Groups
testBug237662 Failure N/A junit.framework.AssertionFailedError at org.eclipse.pde.build.internal.tests.p2.P2Tests.testBug237662(P2Tests.java:290) at org.eclipse.pde.build.tests.PDETestCase.runTest(PDETestCase.java:60) at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:657) at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:310) at org.eclipse.test.CoreTestApplication.runTests(CoreTestApplication.java:36) at org.eclipse.test.CoreTestApplication.run(CoreTestApplication.java:32) at org.eclipse.equinox.internal.app.EclipseAppContainer.callMethodWithException(EclipseAppContainer.java:587) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:198) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:648) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:603) at org.eclipse.equinox.launcher.Main.run(Main.java:1465) at org.eclipse.equinox.launcher.Main.main(Main.java:1438) at org.eclipse.core.launcher.Main.main(Main.java:34)
The problem is in Utils.findDeltaPack() line: 326: deltaLocation = findExecutable(new File(baseLocation.getParent(), "deltapack/eclipse")); This test code assumes it knows where on the file system the delta pack is located relative to the currently running platform's install location. This test always fails when I run it in my workspace (even on Windows). Like in bug 461467, the fix is to skip two additional parent directories.
New Gerrit change created: https://git.eclipse.org/r/44252
Gerrit change https://git.eclipse.org/r/44252 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/?id=c147f309f2dc6afcd5963be11f93bafba240b2bc
Thanks Markus Marking this resolved but will wait for next build results for verification
testBug237662 is still failing.
The first change did fix the delta pack location to where it actually sits in the official Eclipse SDK build. But now the test fails because the Ant files that drive the product build in the test haven't been updated to the new Eclipse.app format. I've never used PDE build, so I'm afraid I can't be of more help here. I can't even tell whether the problem is in the test, or whether an actual product build would fail in the same way.
Increasing the scope of bug to cover all test cases that are failing on MacOS but passing on windows and linux.
For making the test case pass ( I'm not recommending it ) For testBug237662 on MacOS _____________________________ In build.properties in feature org.eclipse.equinox.executable_3.6.100.datestamp (inside delta pack) This change should be made From root.macosx.cocoa.x86_64.permissions.755=${launcherName}.app/Contents/MacOS/${launcherName} to root.macosx.cocoa.x86_64.permissions.755=../eclipse/MacOS/${launcherName} Note that this change is in conflict with change of comment#23 in bug 461467 For testP2SimpleProduct on MacOS ---------------------------- assertTouchPoint configure instruction should be commented out ( also see comment#12 of bug 461467 ) Also assertLogContains -startup and --launcher.library should be commented to make this test pass. In the test.ini file made now these two lines are not there.
For testPublishAndRunSimpleProduct It has the same issue as testP2SimpleProduct . To confirm it, I am putting a temporary check-in http://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/?id=72e0a66ed4978fe4e8c0b187e523dab3f7634ddf I will revert this code commit tomorrow. In my machine setup, this test fails somewhere else on MacOs although I have latest eclipse+code. This is fastest way to verify if this is the only issue here.
The temporary checkin in previous comment fixed the issue and caused no further issue. I will revert the fix today but it established the problem that test case has.
Reverted via http://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/?id=3505239de807b0214c8f8dfb6658d643890a17e0 We should be back to 6 failures on MacOs. Also warning should go off now.
Committed these Pascal's test case fixes http://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/?id=ba7a73220c32629c2a9ec9ed1108e6d66fc97b2e http://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/?id=94260d91b86cecc2f6a3074e1193d0ab3ff75efb http://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/?id=7c4571d68769b1c504071e65ed1d3ce7a30ea3e8
Related defect is bug 461467
Status as of today: - ProductTests.testBug192127 fails on all platforms, bug 468131 could be related - P2Tests.testP2SimpleProduct and P2Tests.testBug237662 only fail on Mac OS X Pascal is going to disable those tests for 4.5.
Here is the commit that disables the tests http://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/?id=aff778aa640de8c879747ba812a164f9537a7480
i guess i encounter this bug now when building for the mac? C:\eclipse\plugins\org.eclipse.pde.build_3.9.100.v20150521-1524\scripts\productBuild\productBuild.xml:45: The following error occurred while executing this line: C:\eclipse\plugins\org.eclipse.pde.build_3.9.100.v20150521-1524\scripts\build.xml:129: The following error occurred while executing this line: C:\eclipse\plugins\org.eclipse.pde.build_3.9.100.v20150521-1524\templates\headless-build\customTargets.xml:13: The following error occurred while executing this line: C:\eclipse\plugins\org.eclipse.pde.build_3.9.100.v20150521-1524\scripts\productBuild\allElements.xml:20: The following error occurred while executing this line: C:\eclipse\plugins\org.eclipse.pde.build_3.9.100.v20150521-1524\scripts\genericTargets.xml:195: The following error occurred while executing this line: C:\Users\Administrator\dev_trunk\eclipse_build\build\forEclipse\package.org.eclipse.pde.build.container.feature.all.xml:27: The following error occurred while executing this line: C:\Users\Administrator\dev_trunk\eclipse_build\build\forEclipse\package.org.eclipse.pde.build.container.feature.all.xml:15: The following error occurred while executing this line: C:\eclipse\plugins\org.eclipse.pde.build_3.9.100.v20150521-1524\scripts\productBuild\allElements.xml:35: The following error occurred while executing this line: C:\Users\Administrator\dev_trunk\eclipse_build\build\forEclipse\package.org.eclipse.pde.build.container.feature.macosx.cocoa.x86_64.xml:92: The following error occurred while executing this line: C:\Users\Administrator\dev_trunk\eclipse_build\build\forEclipse\package.org.eclipse.pde.build.container.feature.macosx.cocoa.x86_64.xml:1741: C:\Users\Administrator\dev_trunk\eclipse_build\build\forEclipse\tmp\servoy\Contents\MacOS does not exist. thats what i get problem is that the MacOS folder is in: C:\Users\Administrator\dev_trunk\eclipse_build\build\forEclipse\tmp\MacOS To patch this locally for now i have to change some code in the delta pack? i used this script: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/plain/scripts/createdeltapack.xml to get the deltapack for 4.5 comment8 says something about changing something but thats doesn't seem to be fully correct for me either. It seems to me that it is something with eclipse.base or the collectingFolder?
Moving to 4.5.2
Moving to 4.6
Moving to 4.7
Currently we are not actively enhancing PDE build anymore. Therefore, I close this bug as WONTFIX. Please reopen, if you plan to provide a fix.
