Bug 462214 - [target] Reload dirties the target editor.
Summary: [target] Reload dirties the target editor.
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 major (vote)
Target Milestone: 4.7 M1   Edit
Assignee: Vikas Chandra CLA
QA Contact:
URL:
Whiteboard:
Keywords: investigate, noteworthy
Depends on: 439034 441190 461549
Blocks: 498184
  Show dependency tree
 
Reported: 2015-03-16 07:02 EDT by Vikas Chandra CLA
Modified: 2016-12-09 05:43 EST (History)
11 users (show)

See Also:

Attachments
Suggested fix. (3.39 KB, patch)
2016-07-04 02:13 EDT, Vikas Chandra CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vikas Chandra CLA 2015-03-16 07:02:32 EDT 
In the target editor, click on reload. The editor is seen as dirty.

It should not be dirty.

Also see Bug 461549
Comment 1 Vikas Chandra CLA 2016-07-04 02:10:12 EDT 
Earlies, reload used to increase the sequence number to force reload. However with the fix of Bug 461549, sequence number is not increased for reload.

So after reload, nothing is changed in target editor and hence target editor should not be dirty.
Comment 2 Vikas Chandra CLA 2016-07-04 02:13:46 EDT 
Created attachment 262883 [details]
Suggested fix.

The fix consists of having fReloadListeners that contains the listeners that should be invoked when reload happens.  Unlike fChangeListeners ( which is used for add, remove, edit, update etc), it doesn't have listeners that make the editor dirty.
Comment 3 Vikas Chandra CLA 2016-07-07 06:33:19 EDT 
Works well while testing.

Fixed via http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=1bdb7dc59f3ed25629d3f21576f76b966eaf4c58
Comment 4 Vikas Chandra CLA 2016-08-01 05:13:20 EDT 
verified on
Eclipse SDK
Version: Oxygen (4.7)
Build id: I20160726-1400
OS: Windows 7, v.6.1, x86_64 / win32