Bug 462073 - [Memory] Make find / replace work for systems using 16 bits addressable sizes
Summary: [Memory] Make find / replace work for systems using 16 bits addressable sizes
Status: NEW
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf-gdb (show other bugs)
Version: 8.6.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-13 10:29 EDT by Alvaro Sanchez-Leon CLA
Modified: 2020-09-04 15:19 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alvaro Sanchez-Leon CLA 2015-03-13 10:29:05 EDT 
The current find / replace feature works when using the common 8 bit addressable size, however if this size is different the search may not succeed or the selected cell is not the correct one.
Comment 1 Eclipse Genie CLA 2015-03-31 11:19:23 EDT 
New Gerrit change created: https://git.eclipse.org/r/44924

WARNING: this patchset contains 1534 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire
Comment 2 Alvaro Sanchez-Leon CLA 2015-03-31 11:34:29 EDT 
The change can be seen as 3 different parts

1) Changes to Separate the actual search functionality from the UI widgets, mainly creating the MemorySearch.java to make it possible to test without requiring interaction with the memory view.

2) The actual changes / adjustments to make consider systems with addressable sizes higher than 1 octet

3) Introduces a new tests.dsf.gdb.ui plugin which depends on the ..tests.dsf.gdb in order to trigger this UI tests.

The changes introducing the tests.dsf.gdb.ui plugin can be easily separated into a second commit, however they were left as part of the same commit in order to make it easier to visualize class accessibility.