Bug 461893 - Problems with custom color selection on a diagram element
Summary: Problems with custom color selection on a diagram element
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 2.0.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 6.0.0   Edit
Assignee: Project Inbox CLA
QA Contact: Florian Barbin CLA
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks: 533509
  Show dependency tree
 
Reported: 2015-03-11 04:13 EDT by Frédéric Madiot CLA
Modified: 2018-06-27 11:55 EDT (History)
8 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Madiot CLA 2015-03-11 04:13:19 EDT
When selecting a custom color on a diagram element (font, border or background color with the "Appearance tab") there are several problems :
- canceling the selection of a custom color set the black color to the selected diagram element
- the default color selected in the palette should be the one already set to the diagram element, not black (when we need to sligthly modify a custom color, we can't start from the color already set). On gradients, the choice should be arbitrary made between foreground and background.
Comment 1 Steve Monnier CLA 2015-03-16 10:42:06 EDT
I have not reproduce this issue. When I "cancel the selection of custom color" using the "reset style properties to default values", it is replaced by the color specified in the VSM.
Can you give a sample to reproduce?
Comment 2 Steve Monnier CLA 2015-03-19 05:58:50 EDT
Some details to reproduce the first issue:
- Select a diagram element
- in the properties view, go to the appearance tab
- Select the fill element action (the rightest one, with a tin of paint icon)
- Do not select one of the color, select the "custom" option
- This opens the OS selection color dialog: just cancel this dialog
-> On windows and linux the element is painted black (not sure how to cancel the dialog on mac)
Comment 3 Julien Dupont CLA 2017-06-06 11:25:53 EDT
There is an other problem.
If you selected nothing in diagram and select a custom color (font, background...)
The focus is changed and open other application (web explorer, text editor...)
Comment 4 Eclipse Genie CLA 2018-04-12 09:48:42 EDT
New Gerrit change created: https://git.eclipse.org/r/121072
Comment 6 Laurent Fasani CLA 2018-04-18 05:24:43 EDT
Steps to validate:
1- create and select a node in a diagram
2- display Properties view/Appearance tab
3- click on text color
-> the selected color must be the current color
4- select another color
5- click on text color
-> the selected color must be the last selected color
6- click "reset Style properties to default value"
-> the button is reset to the default color
7- click on text color
-> the selected color must be the default color
8- repeat steps 3 to 8 with line anf fill button
6- repeat steps 3 to 8 selecting 
   * a diagram
   * an edge
   * a label
Comment 7 Laurent Redor CLA 2018-06-27 11:55:32 EDT
Available in Sirius 6.0.0, see https://wiki.eclipse.org/Sirius/6.0.0 for details