Bug 461048 - API Tools doesn't report breakage if a visibility:=reexport was removed
Summary: API Tools doesn't report breakage if a visibility:=reexport was removed
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 4.5   Edit
Hardware: PC Windows 7
: P3 major (vote)
Target Milestone: 4.23 M1   Edit
Assignee: Vikas Chandra CLA
QA Contact:
URL:
Whiteboard:
Keywords: investigate
Depends on:
Blocks: 517236 578093
  Show dependency tree
 
Reported: 2015-02-27 09:30 EST by Eugene Bova CLA
Modified: 2022-01-07 02:33 EST (History)
3 users (show)

See Also:

Attachments
Fix (12.18 KB, patch)
2016-08-05 04:42 EDT, Vikas Chandra CLA 		no flags Details | Diff
Updated patch (11.68 KB, patch)
2016-08-25 07:05 EDT, Vikas Chandra CLA 		no flags Details | Diff
Patch for merging dependent (+reexported plugins ) in base plugin (13.51 KB, patch)
2016-08-30 04:56 EDT, Vikas Chandra CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Bova CLA 2015-02-27 09:30:17 EST 
It looks like the support for reexported bundles was added here
https://bugs.eclipse.org/bugs/show_bug.cgi?id=258882

But in 4.4.1a, 4.5.0M5 it doesn't work.

The following cases should be reported as a breakage:
Plugin A reexports Plugin B.
B provides API types.

In the new version, A doesn't reexport B anymore (either A doesn't require B at all or A requires B, but visibility:=reexport was removed).
Comment 1 Vikas Chandra CLA 2016-08-05 04:42:38 EDT 
Created attachment 263474 [details]
Fix
Comment 2 Vikas Chandra CLA 2016-08-25 07:05:37 EDT 
Created attachment 263777 [details]
Updated patch

This is the updated patch. BundleMergeSplitTests::test001 fails with this patch. In the failing test case, the baseline contains a plugin and a dependent plugin which is reexported. The project component version now has no reexport since the 2 plugins have been merged into 1. With this change, the test case now fails with "requires major version change". I am investigating this issue.
Comment 3 Vikas Chandra CLA 2016-08-30 04:56:51 EDT 
Created attachment 263841 [details]
Patch for merging dependent (+reexported plugins ) in base plugin

The patch here just checks if the exported packages in the dependent plugin (whose reexport was removed ) are present in base plugin then we don't report that reexport removal as breaking change. Obviously this is not the complete solution.
Comment 4 Eclipse Genie CLA 2020-04-07 06:46:17 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 5 Eclipse Genie CLA 2021-12-28 11:27:23 EST 
New Gerrit change created: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/189171
Comment 7 Vikas Chandra CLA 2021-12-29 02:19:26 EST 
verified on
Version: 2022-03 (4.23)
Build id: I20211228-1800
Comment 8 Eclipse Genie CLA 2022-01-05 04:40:22 EST 
New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/189298