Bug 460018 - Not all git projects connected after "Import Existing Projects into Workspace" wizard
Summary: Not all git projects connected after "Import Existing Projects into Workspace...
Status: ASSIGNED
Alias: None
Product: EGit
Classification: Technology
Component: Core (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 364569
Blocks:
  Show dependency tree
 
Reported: 2015-02-16 09:02 EST by Andrey Loskutov CLA
Modified: 2020-08-13 06:22 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Loskutov CLA 2015-02-16 09:02:08 EST
Looks like we have issues on autoshare projects with the Git repository, at least on Eclipse 3.8.

I'm getting constant user complains that after importing ~180 projects via  "Import Existing Projects into Workspace" wizard not all of them were properly connected to the Git repository.

All those projects are from same repo, and almost all even from the same root in the repo. Interesting observation: the "not connected" projects were alphabetically sorted first, "connected" were at the end of alphabetically sorted projects list.

On the first look the code is in AutoShareProjects.visitConnect() method can be problematic - it too often returns "false" IMHO which might be a problem if the delta contains much more projects. 

I haven't yet debugged this issue - it can be something completely different, like too late Activator activation, so that the plugin just isn't active while the import starts and somehow gets activated in the middle of the import task. This would explain why the "last" few projects were connected, but not the "first" bunch.
Comment 1 Andrey Loskutov CLA 2015-07-17 03:13:21 EDT
See bug 336689: this is a platform issue (bug 364569). The workaround in bug 364569 is ugly.
Comment 2 Lars Vogel CLA 2015-07-17 04:10:19 EDT
(In reply to Andrey Loskutov from comment #1)
> See bug 336689: this is a platform issue (bug 364569). The workaround in bug
> 364569 is ugly.

Is SmartImport not solving this blocker? It is planned to be integrated into M2. https://wiki.eclipse.org/E4/UI/Smart_Import
Comment 3 Andrey Loskutov CLA 2015-07-21 05:00:19 EDT
(In reply to Lars Vogel from comment #2)
> (In reply to Andrey Loskutov from comment #1)
> > See bug 336689: this is a platform issue (bug 364569). The workaround in bug
> > 364569 is ugly.
> 
> Is SmartImport not solving this blocker? It is planned to be integrated into
> M2. https://wiki.eclipse.org/E4/UI/Smart_Import

I don't think so. As long as the old import wizard remains the issue will remain, and if the new import wizard will not provide a chance for team provider to be instantiated *before* the import, this will not work with the new wizard either.

The point is that due the lazy loading if no one activates appropriate team provider plugin before a project is created in workspace, the imported project might be not properly configured. We see exact same issue with egit as SVN in bug 336689 comment 22.