Description Arnaud MERGEY 2015-02-16 08:57:13 EST

Adding a tranling slash to entrypoint path leads to 404 not found.

For example in demo http://rap.eclipsesource.com/demo/release/workbench/app works
but http://rap.eclipsesource.com/demo/release/workbench/app/ return 404

This issue has been introduced in RWTServlet in handleRequest :

Quote:
} else if( "/".equals( request.getPathInfo() ) && "".equals( request.getServletPath() ) ) {
// /context/: root servlet, in this case path info "/" is ok
handleValidRequest( request, response );
} else {
response.sendError( SC_NOT_FOUND );
}


with trailing slash, request.getPathInfo is "/" but request.getServletPath is not "" but "/app"

before 2.3 it used to work because RWTServlet code was different 
we went through handleInvalidRequets

Quote:
if( "/".equals( request.getPathInfo() ) ) {
// In case of "http://example.com/webapp/servlet/" redirect to
// "http://example.com/webapp/servlet" (same URL without trailing slash)
String redirectUrl = createRedirectUrl( request );
response.sendRedirect( response.encodeRedirectURL( redirectUrl ) );
}


so as request.getPathInfo is "/" request were redirected to http://rap.eclipsesource.com/demo/release/workbench/app

This is related to OSGI.
Equinox http service try /app (without trailing slash), if there is nothing registered in /app/
see org.eclipse.equinox.http.servlet.internal.ProxyServlet.service(HttpServletRequest, HttpServletResponse)
Quote:
// perfect match
if (processAlias(req, resp, alias, null))
return;

String extensionAlias = findExtensionAlias(alias);
alias = alias.substring(0, alias.lastIndexOf('/'));

// longest path match
while (alias.length() != 0) {
if (processAlias(req, resp, alias, extensionAlias))
return;
alias = alias.substring(0, alias.lastIndexOf('/'));
}

As RWTSevlet is reached by ProxyServlet with /app, it should not return 404 nn request.getServletPath() return /app in this case that is a valid path where an entrypoint has been registered.
At least if it not considered as a bug, as it worked before 2.3, this change of behavior should be documented.

There is a workaround for each entrypoint, registering a redirect servlet to entry point path for entryPoint path + "/" should work.