Description Alain Picard 2015-02-15 17:53:14 EST

CDOObejctImpl re-implements the method eBasicSetContainer(InternalEObject newContainer, int newContainerFeatureID, NotificationChain msgs) from BasicEObjectImpl, but it breaks when the resource is not a CDOResource.

It starts with:
boolean isResourceRoot = this instanceof CDOResource && ((CDOResource)this).isRoot();

and then if this is not a CDOResource, it won't be root and this cause the following code to act incorrectly:
boolean moved = oldView != null && oldView == newView;
if (!moved && oldResource != null && oldResource != newResource && !isResourceRoot) {
  oldResource.detached(this);
}

compared to the original:
 if (oldResource != newResource && oldResource != null) {
  oldResource.detached(this);
}

the solution that we applied is to call super when not dealing with a CDOResource:
if (!(this instanceof CDOResource)) {
 return super.eBasicSetContainer(newContainer, newContainerFeatureID, msgs);
}
boolean isResourceRoot = ((CDOResource)this).isRoot();

and voila, problem solved.