Bug 459036 - [All Diagrams] Reroute instance association links should be allowed for respected types
Summary: [All Diagrams] Reroute instance association links should be allowed for respe...
Status: NEW
Alias: None
Product: Papyrus
Classification: Modeling
Component: Diagram (show other bugs)
Version: 1.0.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-03 10:03 EST by Alexey Shatilov CLA
Modified: 2017-09-08 10:54 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shatilov CLA 2015-02-03 10:03:18 EST
Steps 
- Create Classes C1, C2, C3
- Create Association A between C1 and C2
- Create 3 objects of respective types: I1:C1, I2:C2, I3:C3
- Try to draw link between I1 and I3 -- not allowed, correct 
- Draw link between I1 and I2, set type to A

- now reroute either end to I3 - it is not allowed, correct
- now create one more instance of type C2, I22:C2 and try to reroute link to I22:C2 => still not allowed
Comment 1 Eclipse Genie CLA 2015-03-02 09:34:28 EST
New Gerrit change created: https://git.eclipse.org/r/43014
Comment 2 Eclipse Genie CLA 2015-04-20 02:43:02 EDT
New Gerrit change created: https://git.eclipse.org/r/46046
Comment 3 Alexey Shatilov CLA 2015-04-20 03:06:34 EDT
Remi Schnekenburger comment from https://git.eclipse.org/r/#/c/43014/
>>Hi,
>>I clicked +2 review too fast. I can find some issues with this contribution: >>1. I was not able to create instance specification link on the current >>verison, but it seems unrelated to your case 2. There are also some issues >>with the given management of the ends. Ex: a. create a instance >>specification link with no association b. reorient its target to a given >>instance specification represented by a classifier (always possible as >>instance spec link is not typed) c. set an association that is not compliant >>with the target instance spec d. it is impossible to reorient the >>association to a target with the right classifier.
>>Please fix the contribution, and also please contribute some tests on this >>aspect, as this is a very fragile aspect of the tool (instance spc can be a >>link or a node)

  - Issue related to the Class diagram migration to ElementType framework. So it's fixed in https://git.eclipse.org/r/46046 gerrit contribution with required tests.

Note, that #46046 covered some other issues related to the InstanceSpecification. There are:
 - InstanceSpecification LinksInstanceSpecificationLink 
     starting/ending on an untyped InstanceSpecification (part of #444606)
 - Bug 459033 - [All Diagrams] Creating instance of association should
     check both ends at once
Comment 4 Camille Letavernier CLA 2015-04-27 09:51:32 EDT
As mentioned in Gerrit 46046:

> I'm not sure we want to enforce "correct by construction" behaviors in this case. It makes it a little bit cumbersome to modify a model with such restrictions, especially since, in UML, InstanceSpecifications are very flexible elements (Which can be used to represent either valid or invalid elements, or partially valid elements)