Bug 45847 - [Builder] Reading build state is slow
Summary: [Builder] Reading build state is slow
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.1.3   Edit
Assignee: Kent Johnson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-10-31 08:07 EST by Jerome Lanneluc CLA
Modified: 2004-03-01 12:16 EST (History)
0 users

See Also:


Attachments
Enable tracing with the attached .options file (2.18 KB, text/plain)
2003-11-04 10:34 EST, Jerome Lanneluc CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2003-10-31 08:07:56 EST
Build 20031029

In a full source workspace with builder tracing on, the first incremental build 
after starting the workbench can take a long time. Most of the time is spent 
reading build states (e.g. jdt.ui state takes more than 11s to read)
Comment 1 Philipe Mulet CLA 2003-10-31 08:09:45 EST
Build states could be read in the PRE_AUTO_BUILD listener, thus benefiting from 
the background build support.
Comment 2 Kent Johnson CLA 2003-11-03 15:43:11 EST
In a 'normal' build, the initial read of the build state for jdt.ui takes ~2 
seconds.

Even with tracing enabled, I didn't see anymore & definitely nothing near 11 
seconds. I think you got hit with a Global GC.
Comment 3 Jerome Lanneluc CLA 2003-11-04 04:04:41 EST
Don't tell me I got hit by a global GC again. This time I got 10406ms to read 
the jdt.ui state.
Comment 4 Kent Johnson CLA 2003-11-04 10:12:28 EST
Well then explain to me how I get 2 seconds doing the exact same thing?
Comment 5 Jerome Lanneluc CLA 2003-11-04 10:24:44 EST
You have a faster machine?
Comment 6 Kent Johnson CLA 2003-11-04 10:27:50 EST
My machine is at most 10-20% faster than yours, not 500%.

How are you getting the 10 second number?
Comment 7 Jerome Lanneluc CLA 2003-11-04 10:34:35 EST
Created attachment 6647 [details]
Enable tracing with the attached .options file
Comment 8 Kent Johnson CLA 2003-11-05 11:23:00 EST
Now intern names and qualified names with new Set classes.

In a full Eclipse source workspace, some of the bucket sizes had reached 2500-
3000 elements.
Comment 9 Jerome Lanneluc CLA 2003-11-05 12:32:15 EST
I'm now seeing 422ms for reading the jdt.ui state. Much better!
Should this improvement be backported to 2.1 maintenance stream?
Comment 10 Kent Johnson CLA 2003-11-05 12:34:21 EST
Philippe already did it.
Comment 11 Philipe Mulet CLA 2003-11-05 12:40:39 EST
Backported to 2.1 stream. No target yet.
Comment 12 David Audel CLA 2003-11-24 12:46:39 EST
Verified for 3.0M5
Comment 13 David Audel CLA 2004-03-01 12:16:53 EST
Verified for 2.1.3 (M20040225)