Bug 457776 - Button order of 'Hot Code Replace Failed' dialog is odd
Summary: Button order of 'Hot Code Replace Failed' dialog is odd
Status: NEW
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.5   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: JDT-Debug-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-17 10:05 EST by Rüdiger Herrmann CLA
Modified: 2015-03-29 07:26 EDT (History)
2 users (show)

See Also:

Attachments
Screenshot of 'Hot Code Replace Failed' dialog (34.12 KB, image/png)
2015-01-17 10:09 EST, Rüdiger Herrmann CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rüdiger Herrmann CLA 2015-01-17 10:05:51 EST 
Currently the dialog has four buttons in this order:
  Continue | Details | Terminate | Restart

While Continue, Terminate and Restart form a group in that they all apply to the debugged process, the Detail does not faill into that category.

I suggest to place the Details button left or right to the Continue, Terminate, Restart group of buttons, separated with some extra space.
E.g.
  Details   | Continue | Terminate | Restart

BTW the 'Do not show again' check box seems misplaced. Shouldn't it left-align with the message text?
Comment 1 Rüdiger Herrmann CLA 2015-01-17 10:09:39 EST 
Created attachment 250014 [details]
Screenshot of 'Hot Code Replace Failed' dialog
Comment 2 Robert Roth CLA 2015-03-27 05:53:06 EDT 
The "Do not show again" checkbox is not misplaced, but is intentionally center-aligned horizontally in the baseclass of the HotCodeReplaceErrorDialog, called ErrorDialogWithToggle, shown for all messages with a "do not show again" toggle.

I agree this is strange, and this needs changing.

Regarding buttons: I'm not sure the extra space between Details and the other buttons is required, but I agree with reordering the buttons, as the new ordering makes more sense.
Comment 3 Rüdiger Herrmann CLA 2015-03-29 07:26:22 EDT 
Left-aligning the 'Do not show again' check box would also better match the appearance of the MessageDialogWithToggle that is used elsewhere.