Bug 456132 - When a DDiagram is locked by using a permission authority some actions are still available
Summary: When a DDiagram is locked by using a permission authority some actions are st...
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 1.0.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 2.0.5   Edit
Assignee: Maxime Porhel CLA
QA Contact: Belqassim Djafer CLA
URL:
Whiteboard:
Keywords: triaged
Depends on: 442761
Blocks: 444267 453994
  Show dependency tree
 
Reported: 2014-12-24 04:35 EST by Pierre-Charles David CLA
Modified: 2015-03-31 10:21 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre-Charles David CLA 2014-12-24 04:35:34 EST 
+++ This bug was initially created as a clone of Bug #442761 +++

In our use case of Sirius, a DDiagram is locked by using a permission authority. In this case Pin/Unpin, Show/Hide, Filter, Layers and Arrange actions should be disabled.
Comment 1 Pierre-Charles David CLA 2014-12-24 04:36:12 EST 
Cloned from bug #442761 to backport the fix into Sirius 2.0.3.
Comment 2 Mickael LANOE CLA 2015-01-13 04:52:10 EST 
Here are commits to backport in order:

5075f9e43f7688dac3bf4c3df14972d1e5043042 [442761] Add comment about regression due to commit 1077eea

59fa392fad179ef1d128b9989d906c6f6fc6fe1e [442761] Disable tab bar actions when a DDiagram is not editable

9f580e416b3072893c546ad3c8da33bc81bb4278 [442761] fix LockedTabBarTest.checkEnabledWithSelectedElement()
Comment 3 Esteban DUGUEPEROUX CLA 2015-01-13 09:25:34 EST 
5075f9e43f7688dac3bf4c3df14972d1e5043042 already exists on v2.0.x as it is a commit common to v2.0.x and to master.

https://git.eclipse.org/r/39491 created to backport 59fa392fad179ef1d128b9989d906c6f6fc6fe1e merged on v2.0.x as 	31de137b641c8ba8914648ef20411d80b6d44637

https://git.eclipse.org/r/#/c/39492/ created to backport 9f580e416b3072893c546ad3c8da33bc81bb4278 merged on v2.0.x as 	be89d0f00472d00330a12489d97f3d183399f7b4
Comment 4 Laurent Fasani CLA 2015-01-20 08:48:54 EST 
Not completely fixed
When user1 locks the diagram, user2 can still expand the menu and access the ArrangeAll and ArrangeAllBorderNodes commands until user2 click in the diagram.
Note that the other menus like filter or layer and disabled
Comment 5 Maxime Porhel CLA 2015-01-20 09:36:00 EST 
The situation is better but this issue needs to be reopen. 
Correction needs to be done on master in Bug 442761 and then backported here.
Comment 6 Eclipse Genie CLA 2015-02-27 11:10:20 EST 
New Gerrit change created: https://git.eclipse.org/r/42920
Comment 8 Esteban DUGUEPEROUX CLA 2015-02-27 11:35:59 EST 
Fixed by MLA
Comment 9 Laurent Redor CLA 2015-03-30 05:46:03 EDT 
Verified on Sirius 2.0.5 [1]

[1] http://download.eclipse.org/sirius/updates/stable/2.0.5-S20150321-000123
Comment 10 Laurent Redor CLA 2015-03-31 10:21:01 EDT 
Available in Sirius 2.0.5.