Description Dave Dyer 2014-12-21 17:05:39 EST

This program incorrectly flags the second clause in "doit1" as
dead.  Run the program to see that it is not.  "doit2" is a slightly
rewritten version of the same function which is not flagged.

package test;

public class ReadStock {
	int actualVotes;
	public ReadStock(int w)
	{	actualVotes = w;
	}
	
	static public void doit1(ReadStock players[])
	{
	ReadStock winner = null;
	ReadStock tie = null;
	
	for(ReadStock p : players)
	{

			if((winner==null)||(p.actualVotes>=winner.actualVotes))
			{	tie = winner;
				winner = p;
			}
	
	}
	if((tie!=null)
		&& (winner!=null) 
		&& (tie.actualVotes==winner.actualVotes))
		{ //incorrectly flagged as dead
                  System.out.println("It's a tie 1");
		}
	}
	
	static public void doit2(ReadStock players[])
	{
	ReadStock winner = null;
	ReadStock tie = null;

	for(ReadStock p : players)
	{
		{	if(winner==null) { winner = p; }
			else if(p.actualVotes>=winner.actualVotes) 
			{	tie = winner;
				winner = p;
			}
		}
	}
	if((tie!=null)
			&& (winner!=null) 
			&& (tie.actualVotes==winner.actualVotes))
		{ System.out.println("Its a tie 2");
		}
	}

	public static void main(String args[])
	{	ReadStock players[] = { new ReadStock(1),new ReadStock(1)};
		doit1(players);
		doit2(players);
	}
}