Bug 455311 - [All Diagrams] Applied stereotypes visibility should be implemented with NamedStyle instead of EAnnotation
Summary: [All Diagrams] Applied stereotypes visibility should be implemented with Name...
Status: RESOLVED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Diagram (show other bugs)
Version: 1.1.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: M6   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard: Stereotype, namedstyle, EAnnotation, ...
Keywords: usability
Depends on: 460255 460259 460264 460271 460273 460274 460356 461559 461561 462359 463605 463903 464409
Blocks: 454739 454777 456199 457024
  Show dependency tree
 
Reported: 2014-12-16 05:06 EST by Celine Janssens CLA
Modified: 2015-06-12 05:16 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Celine Janssens CLA 2014-12-16 05:06:05 EST
The Stereotypes to be displayed are implemented with EAnnotation directly from the Property View. In order to make this feature aligned with the GMF point of view, it is required to modify the framework of the Stereotypes to be displayed by implementing the NameStyle concept using the Notation file.

In Addition, the present Graphical interface to select the stereotypes to be displayed is not clear enough and should be improved.
Comment 1 Celine Janssens CLA 2014-12-18 09:38:15 EST
For information , I'm working on a specification document to have a clear overview about the state of art, the different concepts to change and maybe the side effects that could generate such modifications.
Comment 2 Camille Letavernier CLA 2014-12-19 04:23:09 EST
This is mainly related to the Diagram; I rename the task and change the Component
Comment 3 Christian Damus CLA 2014-12-19 07:27:50 EST
I propose that a consideration in this feature should be that, whereas profile applications can now be loaded and unloaded at any time while a diagram is open, the diagram must find another way to update its presentation to reflect the unloading of a stereotype than by removing the annotation/style/whatever that controls the display of that stereotype in the diagram.

The situation currently is that some edit-policy removes the annotation that names the applied stereotype when the stereotype's profile application is unloaded.  Consequently, when the profile application is later loaded again, the stereotype does not show in the diagram because now the annotation that presented it is absent.
Comment 4 Camille Letavernier CLA 2014-12-19 08:34:57 EST
Hi Christian,

The plan is also to display all stereotypes by default. Moreover, relying on NamedStyles gives an automatic support for CSS, which doesn't need to serialize anything. Finally, I think there is indeed no need to remove any information when un-applying a stereotype (So re-applying it later gives the same graphical results)

All this (and more, probably) should be detailed in the spec document
Comment 5 Eclipse Genie CLA 2015-02-19 08:39:02 EST
WARNING: this patchset contains 1321 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire
Comment 6 Eclipse Genie CLA 2015-02-19 10:40:13 EST
WARNING: this patchset contains 1323 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire
Comment 7 Eclipse Genie CLA 2015-02-23 07:22:42 EST
WARNING: this patchset contains 1315 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire
Comment 8 Eclipse Genie CLA 2015-02-23 08:13:44 EST
WARNING: this patchset contains 1315 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire
Comment 9 Eclipse Genie CLA 2015-02-23 10:00:25 EST
Gerrit change https://git.eclipse.org/r/41903 was merged to [bugs/457024-stereotypeDisplay].
Commit: http://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=5ce8f39a038f850f366509f23647dd321aac17e5

WARNING: this patchset contains 1315 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire
Comment 10 Eclipse Genie CLA 2015-03-04 02:48:08 EST
Gerrit change https://git.eclipse.org/r/42108 was merged to [bugs/457024-stereotypeDisplay].
Commit: http://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=c0f8fe09c5b38e1b5b7aaafdd0afaaece7f2002c
Comment 11 Eclipse Genie CLA 2015-05-06 12:08:40 EDT
New Gerrit change created: https://git.eclipse.org/r/47340
Comment 12 Eclipse Genie CLA 2015-05-06 12:08:43 EDT
New Gerrit change created: https://git.eclipse.org/r/47339

WARNING: this patchset contains 3899 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire
Comment 15 Remi Schnekenburger CLA 2015-06-11 10:14:40 EDT
Can this bug be closed also? It seems the contribution has been merged
Comment 16 Celine Janssens CLA 2015-06-12 05:16:51 EDT
Resolved in Release Mars 1.1.0