Bug 455244 - Quick fix does not work with controlled resources
Summary: Quick fix does not work with controlled resources
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 1.0.1   Edit
Hardware: All All
: P4 normal (vote)
Target Milestone: 3.1.5   Edit
Assignee: Project Inbox CLA
QA Contact: Pierre-Charles David CLA
URL:
Whiteboard:
Keywords: triaged
Depends on: 461740
Blocks: 491216
  Show dependency tree
 
Reported: 2014-12-15 11:13 EST by Stéphane Thibaudeau CLA
Modified: 2016-05-19 08:07 EDT (History)
3 users (show)

See Also:

Attachments
VSM and test project (7.98 KB, application/x-zip-compressed)
2014-12-15 11:13 EST, Stéphane Thibaudeau CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Thibaudeau CLA 2014-12-15 11:13:11 EST 
Created attachment 249436 [details]
VSM and test project

The same quick fix works on a "normal" resource, but when using it with a controlled resource the semantic modification is not done.

The problems ar e:
- no decorator on element with problem despite the problem actually shows up in Problems view
- quick fix does not update the semantic model


Steps to reproduce :

- import the VSM and test project
- in test project, open the diagram on the root EPackage
- if the name does not start with an uppercase letter, change it
- invoke "validate diagram"
- a warning shows up in problems view, a decorator is visible on diagram
- invoke the quick fix, the first letter is now in lowercase
=> OK

repeat the same steps on the last EPackage which is in a controlled resource :
=> warning shows up in problems view : OK
=> no decorator : KO
=> quick fix does not do anything : KO

Regards,
Stephane.
Comment 1 Florian Barbin CLA 2014-12-18 11:17:23 EST 
Reproduced on master (future 3.0.0M5)
Comment 2 Pierre-Charles David CLA 2015-12-15 04:11:50 EST 
Moving out of the 4.0 scope for now, along with all the other issues which were there "by default". This does not mean some of these will not be re-integrated at some point, but for now these issues are not part of the roadmap for 4.0.

If you feel strongly about this removal from 4.0 and/or are ready to sponsor the corresponding work, feel free to comment.
Comment 3 Maxime Porhel CLA 2016-04-07 05:13:23 EDT 
On the same idea than in Bug 461740, when a validation marker points to a DDiagram which is not contained by the main aird but belongs to a referenced analysis (sub aird or other scenario), the quick fix feature does not work: 
 . the "open editor and goto marker" step does not succeed to open the marked diagram editor, instead it opens a text editor.
 . the apply quick fix step does not retrieve its target, or it find it in the dummy resource set of the "ErrorEditor" and then it is not able to apply the fix
 . the revalidate phase, is launched on this same dummy editor, and is not able to relaunch the validation.
Comment 5 Maxime Porhel CLA 2016-04-13 09:41:19 EDT 
Corrected on 3.1.x
Comment 6 Pierre-Charles David CLA 2016-04-14 04:45:03 EDT 
Verified on Sirius 3.1.5rc1.
Comment 7 Maxime Porhel CLA 2016-04-21 08:45:39 EDT 
Available in Sirius 3.1.5.