Bug 455094 - StepIntoSelection cleanup after review
Summary: StepIntoSelection cleanup after review
Status: NEW
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug (show other bugs)
Version: 8.5   Edit
Hardware: PC Linux
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: cdt-debug-inbox@eclipse.org CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-12 16:15 EST by Marc Khouzam CLA
Modified: 2020-09-04 15:18 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Khouzam CLA 2014-12-12 16:15:33 EST 
Thanks to Gerrit's new feature of showing a little speech bubble on a patchset when comments are still in draft, I noticed some comments I had about the StepIntoSelection feature in patchset 10:
  https://git.eclipse.org/r/#/c/11305/10

Some comments are still valid and I will post a patch for review to address them.
Comment 1 Marc Khouzam CLA 2014-12-12 16:17:00 EST 
I've pushed a proposed change that address these old comments:
    https://git.eclipse.org/r/38177

I haven't addressed the multi-process one in GDBRunControl_7_0_NS yet.