Bug 454001 - SemanticBasedDecorator domainClass property section should be required and green in the VSM editor
Summary: SemanticBasedDecorator domainClass property section should be required and gr...
Status: CLOSED WONTFIX
Alias: None
Product: Sirius
Classification: Modeling
Component: Core (show other bugs)
Version: 0.9   Edit
Hardware: PC Windows NT
: P3 normal (vote)
Target Milestone: 2.0.2   Edit
Assignee: Florian Barbin CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on: 435752
Blocks:
  Show dependency tree
 
Reported: 2014-12-03 08:28 EST by Pierre-Charles David CLA
Modified: 2014-12-16 08:34 EST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre-Charles David CLA 2014-12-03 08:28:05 EST 
+++ This bug was initially created as a clone of Bug #435752 +++

Open an odesign file 
Create a DiagramDescription
Create a Decoration set in the default layer
Create a SemanticBasedDecorator

Display its properties. 

The domain class section should be green (see mappings) and required. 
The modification sould be done in the corresponding genmodel.
Comment 1 Pierre-Charles David CLA 2014-12-03 08:28:34 EST 
Clone from bug 435752 to backport in Sirius 2.0.2.
Comment 2 Florian Barbin CLA 2014-12-10 05:19:55 EST 
Backported into branch 2.0.x
Comment 3 Pierre-Charles David CLA 2014-12-15 02:39:38 EST 
Tested on Sirius 2.0.2.201412100936.

The domain class is now green indeed, but the completion inside it seems half-broken. Enter "ecore.EP", hit ctrl-space, and choose "ecore.EPackage". The result should be ecore.EPackage but is "ecore.EPackageackage".

I suspect a dependency between the patch that was cherry-picked from master and other changes on master which have not been backported and modify the insertion/replacement behavior of the completation code (maybe bug #428752).
Comment 4 Pierre-Charles David CLA 2014-12-15 02:49:43 EST 
From the look of the code, commit e94f0e9f0272808dae3b6f090a5a18af28c8030f for this ticket on branch v2.0.x uses the TextContentProposalProvider.bindCompletionProcessor() to setup completion in the domainClass field, but assumes that method has the new behavior it has master after commit b4fd7ce859be1327d7569499a22436fdb1930b3e, which was *not* backported in v2.0.x (and is actually reverted currently on master).
Comment 5 Pierre-Charles David CLA 2014-12-15 02:57:20 EST 
For v2.0.x, we'll simply revert this particular fix, which was not really important, instead of pushing something with a known bug in a maintenance branch.
Comment 6 Pierre-Charles David CLA 2014-12-15 03:11:04 EST 
Change reverted on v2.0.x by 6ebeb1a669aff610918a272aad155ac9955488c9. We won't try to fix this for 2.0.x, it was a minor thing anyway.

Note: some validation is still needed to make sure my revert did not cause any other side-effect.
Comment 7 Pierre-Charles David CLA 2014-12-16 08:34:47 EST 
Available in Sirius 2.0.2.