Bug 453797 - [Security] A user with only Job Read and Build privileges can see the default password stored against a password parameter
Summary: [Security] A user with only Job Read and Build privileges can see the default...
Status: RESOLVED WONTFIX
Alias: None
Product: Hudson
Classification: Technology
Component: Core (show other bugs)
Version: 3.2.1   Edit
Hardware: PC Windows 7
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Winston Prakash CLA
QA Contact: Geoff Waymark CLA
URL:
Whiteboard: candidate-3.4.0
Keywords: security
Depends on:
Blocks:
 
Reported: 2014-12-01 11:55 EST by Geoff Waymark CLA
Modified: 2019-05-14 14:06 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Geoff Waymark CLA 2014-12-01 11:55:57 EST
If a user creates a job with a password parameter which stores a default password another user with only Build and Read privileges can read that stored password from the DOM.

This is the contents of of the inspected password element
<td class="setting-main">

    <div name="parameter" description="Test Password">
        <input type="hidden" value="TEST_PWD" name="name"></input>
        <input class="setting-input " type="password" value="OhNo!" name="value"></input>
    </div>

</td>

Steps to reproduce
1. Turn on security and create two users, one with all rights and one with only Overall Read, and Job, Read and Build.
2. As the privileged user create a job that takes a password parameter and store a default password against it.
3. As the restricted user build the job, on the parameter page inspect the properties of the password field. The class has the value shown in plain text. (see above)
Comment 2 Geoff Waymark CLA 2015-01-23 10:20:10 EST
Retested with these steps and I can still see the supposedly hidden value in the dom tree for the hidden element


<input name="value" type="password" class="setting-input " value="DONOTSHOW">
Comment 3 Winston Prakash CLA 2015-01-28 18:47:44 EST
There are two places.

- Parameter defining  in job Configuration. I substitute dummy password (*****) if user has no configure permission, because user can only view the configuration not submit.   Seems to be fixed.

- Parameter value setting while start building a job  (Here I can not substitute dummy password, other wise dummy password will be submitted to run the job, so password has to be actual password)

Let me see if I can send encrypted password while start building job.  Other option is not to allowing  default password.
Comment 4 Wayne Beaton CLA 2019-05-14 14:06:11 EDT
The Eclipse Hudson project has been terminated and archived.