Bug 453786 - Wrong start location in case of selection from bottom-right to top-left
Summary: Wrong start location in case of selection from bottom-right to top-left
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 0.9   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.0.0M4   Edit
Assignee: Laurent Redor CLA
QA Contact: Belqassim Djafer CLA
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks: 454032
  Show dependency tree
 
Reported: 2014-12-01 11:30 EST by Laurent Redor CLA
Modified: 2015-06-24 11:17 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Redor CLA 2014-12-01 11:30:04 EST 
Since bug 438691, the selection from bottom-right corner to top-left corner is more used than before.

But the start location is wrong. It is shifted from several pixels according to the mouse speed.
Comment 1 Laurent Redor CLA 2014-12-01 11:34:51 EST 
The problem is in RubberbandSelectionTool [1]. This class is a copy of RubberbandSelectionTool from GMF [2]. A corresponding GMF bug 453538 has been created.

The code is not adapted to handle the case of a selection from bottom-right corner to top-left corner.

[1] org.eclipse.sirius.ext.gmf.runtime.diagram.ui.tools.RubberbandSelectionTool
[2] org.eclipse.gmf.runtime.diagram.ui.internal.tools.RubberbandSelectionTool
Comment 2 Laurent Redor CLA 2014-12-02 05:12:23 EST 
Review available here: https://git.eclipse.org/r/37445
Comment 3 Maxime Porhel CLA 2014-12-02 11:44:07 EST 
Laurent, could you put some steps to reproduce more precise than the description which is more an analysis result. It will facilitate the homologation.
Comment 4 Laurent Redor CLA 2014-12-03 03:12:14 EST 
Steps to reproduce:
1-Start the selection just after the bottom-right corner of a node (click on the left button  and keep it pushed)
2-Move quickly the mouse in the direction of the top-left corner of this node (keep the left button pushed)
3-Observe that the starting point of the marquee (selection rectangle in dotted line) is not really where you start the selection
Comment 5 Pierre-Charles David CLA 2014-12-03 10:41:46 EST 
Cloned as 454032 to backport the fix into Sirius 2.0.x.
Comment 7 Belqassim Djafer CLA 2015-04-08 10:00:46 EDT 
Verified on Sirius 3.0.0M6
Comment 8 Pierre-Charles David CLA 2015-06-24 11:17:03 EDT 
Available in Sirius 3.0.0. See https://wiki.eclipse.org/Sirius/3.0.0.