Bug 453699 - [ltk] Replace Text Matches refactoring dialog is missing 'Select All' 'Deselect All' buttons
Summary: [ltk] Replace Text Matches refactoring dialog is missing 'Select All' 'Desele...
Status: ASSIGNED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-01 03:27 EST by Lars Vogel CLA
Modified: 2014-12-08 09:29 EST (History)
4 users (show)

See Also:

Attachments
Screenshot (113.49 KB, image/png)
2014-12-01 07:31 EST, Lars Vogel CLA 		no flags Details
Screenshot with highlights (100.43 KB, image/png)
2014-12-01 07:33 EST, Lars Vogel CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2014-12-01 03:27:47 EST 
I frequently use the Text search dialog with the Replace... Option. The resulting dialog does not offer to deselect / select all option. Would be nice to have these options.
Comment 1 Lars Vogel CLA 2014-12-01 03:28:53 EST 
The review dialog class in which the deselect/ select option is missing is according to plug-in spy:
org.eclipse.ltk.internal.ui.refactoring.RefactoringWizardDialog2
Comment 2 Dani Megert CLA 2014-12-01 07:23:50 EST 
(In reply to Lars Vogel from comment #1)
> The review dialog class in which the deselect/ select option is missing is
> according to plug-in spy:
> org.eclipse.ltk.internal.ui.refactoring.RefactoringWizardDialog2

OK, so this bug is specific to the refactoring wizard?
Comment 3 Lars Vogel CLA 2014-12-01 07:30:55 EST 
(In reply to Dani Megert from comment #2)
> OK, so this bug is specific to the refactoring wizard?

I don't know, I do not have any technical inside of the search and replace functionality of Eclipse. I attach a screenshot to show what I mean.
Comment 4 Lars Vogel CLA 2014-12-01 07:31:15 EST 
Created attachment 249059 [details]
Screenshot
Comment 5 Lars Vogel CLA 2014-12-01 07:33:49 EST 
Created attachment 249060 [details]
Screenshot with highlights
Comment 6 Markus Keller CLA 2014-12-08 09:29:13 EST 
Note that you can also:
- perform the search,
- inspect the results in the Search view,
- delete matches you don't want to to touch (Delete key), and finally
- use context menu > Replace All... to replace all the remaining matches (but not the ones you've deleted).