Bug 453547 - SemanticChangedCommand should not be here
Summary: SemanticChangedCommand should not be here
Status: NEW
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 2.0.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2014-11-28 11:39 EST by Esteban DUGUEPEROUX CLA
Modified: 2015-01-05 12:01 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Esteban DUGUEPEROUX CLA 2014-11-28 11:39:04 EST
SemanticChangedCommand is called in precommit to do local refresh of DRefreshable even in auto-refresh and do refresh of EditPart (in precommit also).

The local/partial commit in SemanticChangedCommand should be called only in manual-refresh in a separate precommit. And Editpart refresh should be handled through DiagramEventBroker.
Comment 1 Florian Barbin CLA 2014-12-18 05:21:35 EST
Can you provide more details about the consequences (with a scenario)? 

You describe a solution but this issue will be complicated to test during the validation without more details.
Comment 2 Pierre-Charles David CLA 2014-12-22 07:27:21 EST
Esteban, from your description this looks like a performance issue (causing too many unneeded DRefreshable.refresh() and EditPart.refresh() calls). Is this correct or can this also produce invalid results (and not just slowdowns)? If this is about performance, please add the corresponding keyword, and if possible some measures (ideally times, otherwise suspiciously high invocation counts for some methods).

Note that this may be one of the causes for what is described in bug #443518.
Comment 3 Esteban DUGUEPEROUX CLA 2015-01-05 11:54:28 EST
This bugzilla is to show that some refresh is called in bad places.
Fixing that will improve performance, I will try to do some performance measures.