Bug 453036 - False "The semantic model was not correctly updated" error with edge reconnection
Summary: False "The semantic model was not correctly updated" error with edge reconnec...
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 1.0.1   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.0.0M4   Edit
Assignee: Florian Barbin CLA
QA Contact: Belqassim Djafer CLA
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks: 456080
  Show dependency tree
 
Reported: 2014-11-24 09:01 EST by Stéphane Thibaudeau CLA
Modified: 2015-06-24 11:14 EDT (History)
3 users (show)

See Also:


Attachments
test project to reproduce (2.95 KB, application/x-zip-compressed)
2014-11-24 09:01 EST, Stéphane Thibaudeau CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Thibaudeau CLA 2014-11-24 09:01:42 EST
Created attachment 248867 [details]
test project to reproduce

Eclipse Luna : 4.4.0
Sirius : 1.0.1
Ecore tools : 2.0.0.201406112035

When reconnecting, a warning "The semantic model was not correctly updated by the reconnect tool, the diagram part of the reconnect cannot be done" sometimes pops up in Error log. The reconnection is cancelled and the command stack is flushed (no Ctrl-Z anymore).

This behaviour is easily seen using ecore tools.

Steps to reproduce : 

1 - import the given test project
2 - open the class diagram
3 - try some reconnections
4 - sometimes the error pops up in error log and the reconnection is cancelled.

Cases in which I get the error on my computer :

Case 1 :
- from the starting point (reference betwenn EClass1 and EClass2)
- try to reconnect the Eclass1's side to have an edge between EClass3 and ECLass2 => error

Case 2 :
- from the starting point (EClass1 <-> Eclass2)
- do a few reconnections which work (EClass1 <-> Eclass3, EClass1 <-> EClass4, EClass2 <-> EClass4, EClass3 <-> EClass4)
- now try to do EClass3 <-> Eclass2 => Error.
Comment 1 Florian Barbin CLA 2014-11-25 05:38:09 EST
A patch to fixe this issue: https://git.eclipse.org/r/#/c/36946/
Comment 2 Florian Barbin CLA 2014-12-04 04:42:12 EST
Fixed by this commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=aa71fd0455b1bdaea07dee635ede6b09d9a7c146

This fix is a good backport candidate!
Comment 3 Florian Barbin CLA 2014-12-09 03:56:00 EST
This commit delete an obsolete test that fails with the new behavior: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c4c4d5784f891c6748ed5c54e5d40a12505c4453
Comment 4 Pierre-Charles David CLA 2014-12-23 09:30:39 EST
Cloned as bug #456080 to backport the fix into Sirius 2.0.x.
Comment 5 Belqassim Djafer CLA 2015-04-08 09:25:09 EDT
Verified on Sirius 3.0.0M6
Comment 6 Pierre-Charles David CLA 2015-06-24 11:14:27 EDT
Available in Sirius 3.0.0. See https://wiki.eclipse.org/Sirius/3.0.0.