Bug 451546 - The action "create root lines" in the toolbar does nothing by default
Summary: The action "create root lines" in the toolbar does nothing by default
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Table (show other bugs)
Version: 2.0.0   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 3.0.0M5   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard: trivial
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2014-11-14 08:46 EST by Esteban DUGUEPEROUX CLA
Modified: 2015-06-24 11:15 EDT (History)
4 users (show)

See Also:

Attachments
Example Modeling Project to show the issue on tree and table (2.67 KB, application/zip)
2014-11-14 08:46 EST, Esteban DUGUEPEROUX CLA 		no flags Details
New test project (3.99 KB, application/zip)
2014-12-29 11:28 EST, Pierre-Charles David CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Esteban DUGUEPEROUX CLA 2014-11-14 08:46:45 EST 
Created attachment 248666 [details]
Example Modeling Project to show the issue on tree and table

On table representation when only one line tool creation is available, the "create root lines" button should trigger the creation of the line.
In attachement a Modeling Project example to see that. In addition when a single creation tool is available to create root line/tree item the button should have label of tool.
Comment 1 Laurent Redor CLA 2014-11-19 04:09:47 EST 
I think it would be preferable to take the first "line creation tool" as the default one.
If there is only one "line creation tool", it will be the default one.

The button should have the label of the last used tool. At the creation, the default tool label should be used.

A better enhancement will be to allow the specifier to choose the default tool directly in the VSM. This will be probably another issue.
Comment 2 Laurent Fasani CLA 2014-12-03 04:38:58 EST 
currently working on it
Comment 3 Laurent Fasani CLA 2014-12-29 10:48:15 EST 
the fix cover the dropdown toolbar either for tree and table representation editor 
 https://git.eclipse.org/r/38812
Comment 4 Pierre-Charles David CLA 2014-12-29 11:28:01 EST 
Created attachment 249650 [details]
New test project

Slightly improved test project, with 2 different tools for each of the table/tree editors. Needed to see that with the change, the menu remembers which of the available tools was called last, and invoke that one by default.
Comment 5 Pierre-Charles David CLA 2014-12-31 08:00:49 EST 
Fixed by d193dc855364792cff84b6acc12649e49e3e36b9.
Comment 6 Belqassim Djafer CLA 2015-04-09 10:48:09 EDT 
Verified on Sirius 3.0.0M6
Comment 7 Pierre-Charles David CLA 2015-06-24 11:15:54 EDT 
Available in Sirius 3.0.0. See https://wiki.eclipse.org/Sirius/3.0.0.