Community
Participate
Working Groups
Very strange separation of the long line and many spaces before semicolon (";") Try to format this code =====start of the Test.java code package test; import java.util.Hashtable; public class Test { public Test() { Hashtable fields; // TODO some todo text // direct field names // ==== Dictionaries //CountryDictInfo fields = new Hashtable(); fields.put("name", "Name"); fields.put("numericCode", "NumericCode"); getSqls() .put("finmon.domain.dictionary", new SomeFieldSQLDescriptor( this, "SELECT * FROM CountryDict WHERE ", " ORDER BY Name", fields)) ; } } =======end of code Pay attention on spliting the line and where putting the last semicolon getSqls().put("finmon.domain.dictionary", new SomeFieldSQLDescriptor(this, "SELECT * FROM CountryDict WHERE ", " ORDER BY Name", fields));
With latest code, it returns: package test; import java.util.Hashtable; public class Test { public Test() { Hashtable fields; // TODO some todo text // direct field names // ==== Dictionaries //CountryDictInfo fields = new Hashtable(); fields.put("name", "Name"); fields.put("numericCode", "NumericCode"); getSqls() .put("finmon.domain.dictionary", new SomeFieldSQLDescriptor( this, "SELECT * FROM CountryDict WHERE ", " ORDER BY Name", fields)); } } Does this look acceptable?
Not yet. fields.put("numericCode", "NumericCode"); getSqls() .put("finmon.domain.dictionary", new SomeFieldSQLDescriptor( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this, "SELECT * FROM CountryDict WHERE ", " ORDER BY Name", fields)); Why you split getSqls() and .put. You win just 1 char but not the clearness. I think old formatter do it fine and readable: getSqls().put( "finmon.domain.dictionary", new SomeFieldSQLDescriptor( this, "SELECT * FROM CountryDict WHERE ", " ORDER BY Name", fields)); If hole arguments line must be droped then each argument must be appeared on new line with ident (4 spaces) P.S. I think formatter must use Sun standard Code Conventions for the Java. http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html It's very pragmatic and make code very readable. And its looks like Standard!
This is a different problem. The remaining problem is a duplicate of bug 44642.
Close as duplicate of bug 44642, because the first problem is already fixed. *** This bug has been marked as a duplicate of 44642 ***
