Bug 45112 - Use Javadoc instead of Annotation for comment compiler parsing
Summary: Use Javadoc instead of Annotation for comment compiler parsing
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 M5   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-10-17 11:33 EDT by Martin Aeschlimann CLA
Modified: 2003-11-21 09:10 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2003-10-17 11:33:33 EDT
20031015

The warnings for problems in javadoc tags say: 'Annotation: xxx'
I would suggest to not use 'Annotation' (already used my the editor e.g. Java ->
Editor -> Annotations' for something different.

'Javadoc tags' seems to me the better description.
Comment 1 Olivier Thomann CLA 2003-11-08 19:16:43 EST
Annotation also describes the new metadata facility. See JSR175. We might have
some problems for the naming of the ast classes.
Comment 2 Frederic Fusier CLA 2003-11-13 12:56:02 EST
All classes, method, fields names which contain 'annotation' will be changed.
'annotation' will be replaced by 'javadoc' with corresponding character case.

Also all comments which will be changed to avoid confusion...
Comment 3 Frederic Fusier CLA 2003-11-13 13:33:32 EST
Of course also replace 'Annotation: ....' in problems description 
with 'Javadoc: ...'.

As some problem descriptions already contain 'javadoc':
Annotation: Unexpected javadoc entry
Annotation: Missing javadoc entry for parameter {0}
Annotation: Duplicate entry for parameter
Annotation: Missing javadoc entry for return type
Annotation: Duplicate entry for return type
Annotation: Missing javadoc entry for declared exception {0}
Annotation: Duplicate entry for thrown exception
Annotation: Missing javadoc comment for public declaration

they will be replaced with following ones:
Javadoc: Unexpected tag
Javadoc: Missing tag for parameter {0}
Javadoc: Duplicate tag for parameter
Javadoc: Missing tag for return type
Javadoc: Duplicate tag for return type
Javadoc: Missing tag for declared exception {0}
Javadoc: Duplicate tag for thrown exception
Javadoc: Missing comment for public declaration

For all other description, only 'Annotation:' prefix will be changed 
to 'Javadoc:'
Comment 4 Frederic Fusier CLA 2003-11-13 13:38:07 EST
Martin,

Please note that due to conflict with Annotation JDK 1.5 grammar, ids for 
optional compiler problem to signal problems with javadoc will be changed.

New definitions for these options will be:

COMPILER / Reporting Invalid Javadoc Comment
  - option id: "org.eclipse.jdt.core.compiler.problem.invalidJavadoc"

COMPILER / Reporting Missing Javadoc Comment
  - option id: "org.eclipse.jdt.core.compiler.problem.missingJavadoc"

How can we synchronize this change?
Comment 5 Martin Aeschlimann CLA 2003-11-14 04:06:23 EST
If you can make me a new jdt.core drop as soon as you released the changes, 
then I can adapt to it immediatly as well.


BTW: I wouldn't qualify everything with 'Javadoc:', the other error messages 
don't do that either.
Just write 'Missing Javadoc tag', 'Missing Javadoc comment for public 
declaration'
Comment 6 Frederic Fusier CLA 2003-11-17 05:28:30 EST
Fixed.

No specific test cases added, only rerun those already existing.

Martin,
I let prefix 'Javadoc:' in problems description as this kind of problems are 
really specific for the compiler: they are not really against the code but in 
comments...
This is really useful as we use some of 'standard' compiler problem description 
(not found, not visible, etc...) while resolving bindings for references and we 
want to distinguish them easily from those which are in the code (warning/error 
levels are not enough to do this distinction).
Comment 7 David Audel CLA 2003-11-21 09:10:24 EST
Verified.