Bug 44979 - [content assist] Code completion popup comes up too small
Summary: [content assist] Code completion popup comes up too small
Status: ASSIGNED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 enhancement with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-10-15 19:39 EDT by Brett Kotch CLA
Modified: 2004-05-27 09:14 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brett Kotch CLA 2003-10-15 19:39:27 EDT
Type 

String s = new String([ctrl-space])

The resulting window uses scrollbars eventhough there is more enough screen 
realestate for it to open up into. Scrollbars for popups like this should 
rarely ... if ever.
Comment 1 Martin Aeschlimann CLA 2003-10-16 04:26:38 EDT
I agree on that. I don't think we can really get rid of scrollbars, but it would
makes sense to have the size of the code assist window either configurable
(urgh!) or have a heuristic that makes it bigger if it thinks that I can afford
it (because I have a high screen resolution)
Comment 2 Dani Megert CLA 2003-10-16 05:28:13 EDT

*** This bug has been marked as a duplicate of 12238 ***
Comment 3 Brett Kotch CLA 2003-10-16 12:33:58 EDT
I don't think this is a duplicate of bug 12238. That bug says we should be able 
to resize it. This one is saying that in most cases we shouldn't even have to 
resize it. 


Comment 4 Dani Megert CLA 2003-10-17 03:12:38 EDT
Is I agree it's not a duplicate. Was too fast when comment 1 about configurability.
Comment 5 Brett Kotch CLA 2003-10-17 09:13:27 EDT
Some thoughts about the size of the popup. 

The popup should adapt to the size of the width and height. 
The height should not exceede a certain size (Too large a window is also not a 
good thing.) 
The width should almost always entirly reflect the text in the window. 
(Horizontal scrolling is MUCH worse than vertical scrolling and should be 
avoided at all costs. There is a good explanation of the evils of horizontal 
scrollings in Alan Cooper's book, About Face 2.0)

In that book he says:
Scrolling text horizontally is a terrible thing, and should never, ever be 
done. When a text list is scrolled horizontally, it hides from view on or more 
of the first letters of every single line of text showing. This makes *none* of 
the lines readable and the continuity of the text is utterly destroyed. 

He then states the obvious axiom from the above paragraph.
    NEVER SCROLL TEXT HORIZONTALLY

Along those lines, I noticed that this has a priority of P4, and IMHO, this is 
too low. Usabiliy issues, in many respects, are just as important as defects, 
and in many cases are more important. Considering that this window is used so 
often, I think this is one of those cases. 


Comment 6 Dani Megert CLA 2003-10-17 10:05:52 EDT
The reason for P4 is that we think once you can resize and the size will be kept
you can configure it yourself. This will be quite easy to implement while the
adding auto-sizing is quite difficult and time consuming to get it right on all
platforms and displays.

You might want to implement this and contribute to Eclipse.
Comment 7 Brett Kotch CLA 2003-10-17 10:10:21 EDT
> The reason for P4 is that we think once you can resize and the size will be 
kept you can configure it yourself.

That is not currently the behavior. If I hit ctrl-space in the case described, 
and resize the window. Close the window and hit ctrl-space again. The window is 
not the size that I expanded it to. 

Comment 8 Brett Kotch CLA 2003-10-17 10:11:24 EDT
The behavior described in this defect, as well as the resizing the window not 
being persisted is in version 2.1.1. Changed version to reflect this. 
Comment 9 Dani Megert CLA 2003-10-17 10:38:34 EDT
The resized size is not yet stored (see bug 12238, comment 5).
Comment 10 Kai-Uwe Maetzel CLA 2004-02-09 14:32:03 EST
Moving to M8, as not yet done.
Comment 11 Dani Megert CLA 2004-03-23 02:32:09 EST
Not fixed in M8 but you can now resize it once and then it keeps that size.
Comment 12 Kai-Uwe Maetzel CLA 2004-05-27 09:14:15 EDT
Removing mile stone. Post 3.0.