Community
Participate
Working Groups
We still have know issues with Bug 437538: In the case of auto-size containers, we compute a wrong size in pure GMF coordinate system. That happens with long labels for instance since we do not compute the real label size according to the font name, the font-size, etc. According to these limitations, we have two identified cases where the edge centering could be wrong: * When performing an arrange-all (or selection) * When re-sizing one of the edge ends shape.
Created attachment 248231 [details] centered edge representation New issue detected, to reproduce : 1- extract and import the attached project into the workspace. 2- open centered edge representation 3- Ensure that the centered edge style = Target. 4- move the source extremity of "edge 6" without changing side (the edge should stay right) 4- KO -> the edge target extremity moved.
In step 3, I meant : Ensure that the centered edge style of "edge 6" = Target.
Bug 437528 (In reply to Florian Barbin from comment #0) > We still have know issues with Bug 437538: > > In the case of auto-size containers, we compute a wrong size in pure GMF > coordinate system. That happens with long labels for instance since we do > not compute the real label size according to the font name, the font-size, > etc. > > According to these limitations, we have two identified cases where the edge > centering could be wrong: > > * When performing an arrange-all (or selection) > * When re-sizing one of the edge ends shape.
Created attachment 248307 [details] Reconnect issue A issue on the reconnect has been fixed by this commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=220c31aa503c821bb482632f90c004d4e11081e1 Steps to reproduce: * Import the use case * Open "new testReconnect" * Reconnect the edge from "eClass4" to "eClass5" * The new target should be centered (that was the KO)
Created attachment 248321 [details] Resize shape and centered edge issue When resizing an "auto-size" shape, the edge centering can be broken since we can compute a wrong size. Steps to reproduce: * Import the use case and open the diagram. * Resize the edge "ref0" target to east for instance. * The edge target is no longer centered. => KO https://git.eclipse.org/r/#/c/35462/
Created attachment 248349 [details] Resize shape and centered edge issue
Created attachment 248350 [details] Resizing over bendpoints
With the use case https://bugs.eclipse.org/bugs/attachment.cgi?id=248349 * Open the diagram * Re-size the edge target class so that several bendpoints are within the new bounds. (See screenshot https://bugs.eclipse.org/bugs/attachment.cgi?id=248350) * The edge is no longer centered since the last segment is within the target bounds. KO
Comment 8 Review: https://git.eclipse.org/r/#/c/35795/
Created attachment 248358 [details] Issue When resizing With the Comment 8 use case, the edge have strange bendpoints (see attached screenshot) This issue is fixed by this patch: https://git.eclipse.org/r/#/c/35882/
Comment 1 patch: https://git.eclipse.org/r/#/c/35935/
Created attachment 248719 [details] two or tree bendpoints rectilinear cases Import the given use case and open the representation. * Set the centering property for all edges to "BOTH". * "ReferenceB" source is not centered => KO * "ReferenceA" target is not centered => KO * "ReferenceC" source is not centered => KO This patch fixes this issue: https://git.eclipse.org/r/#/c/36612/
Fixed: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=deae56838017dae692745c2579845ad934832575 http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=2889f4405e6e11df2ac4a759087f936571883056
At first glance the patch looks a little more impacting that what I am comfortable with backporting, at least not without further study. I'm leaving the "backport" keyword so that we may reconsider it later.
After further discussion with Laurent and Florian, it seems important enough that we want to make the effort to backport it into 2.0.2, so cloned as bug 454014 for that.
A regression during the reconnect of a centered edge has been fixed; See https://bugs.eclipse.org/bugs/show_bug.cgi?id=454014#c3. Fixed on master by commit http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=1c72fa0bab233c87585c96f7ccce750cb64ea778
KO on Sirius 3.0.0M6 and Sirius2.0.0
(In reply to Belqassim Djafer from comment #17) > KO on Sirius 3.0.0M6 and Sirius2.0.0 When resize a bordered node which is referenced by a centered edge (target or source and target centered edge), several bendpoints change.
See Belqassim's comment.
Complete scenario corresponding to comment 18: * Import project "Reconnect issue" of https://bugs.eclipse.org/bugs/attachment.cgi?id=248307 * Open the diagram "new testReconnect" * Zoom to 200% * Scroll the diagram to the origin (to avoid potential scroll effects) * Resize "eClass4" to the bottom (align bottom of "eClass4" to the bottom of "Package2") * The edge between "eClass2" and "eClass4" does not move --> OK * Select edge between "eClass2" and "eClass4" * In the Properties view, in Style tab, change Centered property to Both * Resize "eClass4" to the bottom (align bottom of "eClass4" to the bottom of "Package2") * All bendpoints of the edge between "eClass2" and "eClass4" move --> OK. Only the last segment should move (as in zoom 100%).
(In reply to Laurent Redor from comment #20) > * All bendpoints of the edge between "eClass2" and "eClass4" move --> OK. > Only the last segment should move (as in zoom 100%). Of course, this is KO (not OK).
New Gerrit change created: https://git.eclipse.org/r/47271
Gerrit change https://git.eclipse.org/r/47271 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=8bddcd9682ac7d30fa294cb6c4ca1ff8bd2df47e
Pb of comment 20 resolved with above commit
Created attachment 253637 [details] testReconnect for comment 25 When resize a border node which is referenced by a centered edge, bendpoints change. To reproduce: 1- Import the attached project. 2- Open the diagram "new testReconnect". 3- Zoom to 175% or 125%. 4- Resize "eClass4" to the right (align the left side of "eClass4" to the left side of "eClass3") -> Only the last segment of the edge between 'eClass1' and 'eClass4' move -> OK. 5- Make undo. 6- Select the edge between 'eClass1' and 'eClass4'. 7- In the Properties view, in Style tab, change Centered property to Both. 8- Repeat step 4 -> KO : All bendpoints of the edge move.
see belqassim comment 25
For information, the bug of comment 25 is not present with zoom 200%.
New Gerrit change created: https://git.eclipse.org/r/48740
Gerrit change https://git.eclipse.org/r/48740 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=d4c2e860ddfe828af79d66b5917a60c7e9dcd840
Resolved in 3.0.0rc3
Available in Sirius 3.0.0. See https://wiki.eclipse.org/Sirius/3.0.0.
