Bug 448373 - Control action does not work with the IsModifiedSavingPolicy
Summary: Control action does not work with the IsModifiedSavingPolicy
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Core (show other bugs)
Version: 2.0.0   Edit
Hardware: PC Mac OS X
: P1 major (vote)
Target Milestone: 3.0.0M6   Edit
Assignee: Steve Monnier CLA
QA Contact:
URL:
Whiteboard:
Keywords: needinfo, triaged
Depends on:
Blocks: 448655
  Show dependency tree
 
Reported: 2014-10-22 10:10 EDT by Maxime Porhel CLA
Modified: 2015-06-24 11:16 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Porhel CLA 2014-10-22 10:10:02 EDT
Steps to reproduce: 
 1. Create a Ecore Modeling Project
 2. Add a package p1 in p0 and a class in it
 3. Create a new representation on the diagram
 4. In the model explorer right clic p1 and select control, choose to move the representation a sub aird.
 5. At the end of the control, you must have a new aird and a new ecore file with a decorated package without any child. In the initial ecore file, you must see the same structure than before the control p0, p1, c1 (child of p1) but p1 has the "isControlled" decorator.

Now enable the IsModifiedSavingPolicy
Replay the previous scenario
 5. Now the ecore file is not created but p1 is displayed as controlled. This seems to indicate that the policy did not detect that the main ecore and the controlled one need to be saved. (Open in text editor or reflective ecore editor the main ecore to see if it has been saved). Also check the sub aird creation.


To enable the IsModifiedSavingPolicy: make sure you have Xtext and the Xtext bridge in your environnement, and add at least one XText model in the modeling project between steps 1 and 2.
Comment 1 Florian Barbin CLA 2015-01-21 03:29:40 EST
The IsModifiedSavingPolicy is now the default Saving Policy. However, even with the XText bridge, I did not reproduce this issue. (System Linux 64bits)
Comment 2 Florian Barbin CLA 2015-01-21 05:13:15 EST
FI, I did not reproduce with an XText resource within the modeling project.
Comment 3 Pierre-Charles David CLA 2015-03-04 04:42:22 EST
We need to do some additional checks under Windows before we can confirm it is indeed fixed.
Comment 4 Steve Monnier CLA 2015-03-17 06:04:44 EDT
I have not reproduce the issue on Windows.
However, I have experienced and fixed the issue 462336.
Comment 5 Belqassim Djafer CLA 2015-04-10 11:27:10 EDT
Verified on Sirius 3.0.0M6
Comment 6 Pierre-Charles David CLA 2015-06-24 11:16:44 EDT
Available in Sirius 3.0.0. See https://wiki.eclipse.org/Sirius/3.0.0.