Bug 446546 - [CSSLint] Use configurable severities as ruleset rather than a post processing filter
Summary: [CSSLint] Use configurable severities as ruleset rather than a post processin...
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: 6.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 7.0   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on: 445540
Blocks:
  Show dependency tree
 
Reported: 2014-10-09 17:20 EDT by Curtis Windatt CLA
Modified: 2014-10-14 16:47 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2014-10-09 17:20:42 EDT 
The current implementation of configurable severities for CSSLint simply filters out problems thta match a rule who's severity is 'ignore'.  Instead we should be creating a ruleset to pass into the CSSLint.verify() call.  This allows those rules to be skipped entirely.
Comment 1 Curtis Windatt CLA 2014-10-14 16:47:26 EDT 
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=6ea2bae3faecc9772b4ee5ddec074188ae903ad3
Sets a ruleset rather than changing severities after the fact

Also fixes an issue with the settings name

This allows embedded rulesets to work (Bug 445544).  

CSSLint always changes the severity of parsing errors to 'error' so I removed the severity option from the settings.