Bug 446437 - [ltk] AFE in org.eclipse.ltk.core.refactoring.CompositeChange.add - change.getParent()is not null (err_grp: d225ec0b)
Summary: [ltk] AFE in org.eclipse.ltk.core.refactoring.CompositeChange.add - change.ge...
Status: REOPENED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-09 06:44 EDT by EPP Error Reports CLA
Modified: 2022-05-24 11:53 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description EPP Error Reports CLA 2014-10-09 06:44:18 EDT
Hello committers,

we received a new error report for Eclipse 4.4.1.M20140925-0400.


General Information:
    anonymous-id:         4a814b2d-7243-4e42-b54a-2ae5d8456eb0
    eclipse-build-id:     4.4.1.M20140925-0400
    eclipse-product:      org.eclipse.epp.package.rcp.product
    operating system:     MacOSX 10.9.5 (x86_64) - cocoa
    java-runtime-version: 1.8.0_20-b26

The following plug-ins were present on the execution stack (*):
    1. org.eclipse.core.resources_3.9.1.v20140825-1431
    2. org.eclipse.core.runtime_3.10.0.v20140318-2214
    3. org.eclipse.jface_3.10.1.v20140813-1009
    4. org.eclipse.ltk.core.refactoring_3.6.101.v20140817-1500
    5. org.eclipse.ltk.ui.refactoring_3.7.100.v20140324-1358


Error Status:

    code:                   10.000
    plugin:                 org.eclipse.ltk.ui.refactoring_3.7.100.v20140324-1358
    message:                Internal Error
    fingerprint:            d225ec0b
    exception class:        org.eclipse.core.runtime.AssertionFailedException
    exception message:      assertion failed: 
    number of children:     0
    
    org.eclipse.core.runtime.AssertionFailedException: assertion failed: 
    at org.eclipse.core.runtime.Assert.isTrue(Assert.java:110)
    at org.eclipse.core.runtime.Assert.isTrue(Assert.java:96)
    at org.eclipse.ltk.core.refactoring.CompositeChange.add(CompositeChange.java:111)
    at org.eclipse.ltk.core.refactoring.CompositeChange.addAll(CompositeChange.java:124)
    at org.eclipse.ltk.core.refactoring.CompositeChange.<init>(CompositeChange.java:69)
    at org.eclipse.ltk.core.refactoring.CompositeChange.createUndoChange(CompositeChange.java:456)
    at org.eclipse.ltk.core.refactoring.CompositeChange.handleUndos(CompositeChange.java:345)
    at org.eclipse.ltk.core.refactoring.CompositeChange.perform(CompositeChange.java:323)
    at org.eclipse.ltk.core.refactoring.PerformChangeOperation$1.run(PerformChangeOperation.java:258)
    at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2313)
    at org.eclipse.ltk.core.refactoring.PerformChangeOperation.executeChange(PerformChangeOperation.java:306)
    at org.eclipse.ltk.internal.ui.refactoring.UIPerformChangeOperation.executeChange(UIPerformChangeOperation.java:92)
    at org.eclipse.ltk.core.refactoring.PerformChangeOperation.run(PerformChangeOperation.java:218)
    at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2313)
    at org.eclipse.ltk.internal.ui.refactoring.WorkbenchRunnableAdapter.run(WorkbenchRunnableAdapter.java:87)
    at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:122)
   

    

Messages, stacktraces, and nested status objects may be shortened. Please visit 
http://dev.eclipse.org/recommenders/committers/confess/0.5/reports/54366703e4b00f2b25241a49
for the complete error log.


Some general information and guidelines about how to use this bug report:

1. Feel free to move this bug to your own product and components. Please note
   that this bug is only accessible to Eclipse committers. If you move this bug
   please make sure that it's still in the "Security Advisor" group.

2. The bug contents of the fields status, resolution, keywords, and whitelist
   are presented to reporters. If you needs more information, please set the
   keyword "needinfo". This will trigger a specialized dialog asking the user
   to provide further details.

3. Use the following resolutions for the following situations:
   * CLOSED / FIXED: This bug has been fixed. Please provide additional
     information in the whiteboard field.
   * CLOSED / WORKSFORME: Use this resolution if you can't reproduce this issue
     and request further information. Please use the whiteboard text to specify
     more details what a user should provide and how.
   * CLOSED / INVALID: Use this resolution if the reported problem is a
     'user-configuration' problem. Please consider giving hints how to fix
     these issues in the whiteboard field.
   * CLOSED / NOT ECLIPSE: Use this if the problem is caused by another plugin
     not developed at Eclipse.org
   * CLOSED / MOVED: If this bug has been moved else where. Please provide more 
     information (e.g. a link) in the whiteboard field.

4. Please remember that only committers can view and comment on this bug. You
   may, however, manually add the reporting user to the bug's cc list. But keep
   in mind that the report may contains sensitive information.

5. If you are missing a feature, please file a enhancement request here:
   https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Recommenders.Incubator&component=Stacktraces
    
 

Thank you for your assistance.
Your friendly error-reports-inbox.


--
* Note: The list of present bundles and their respective versions was
  calculated by package naming heuristics. This may or may not reflect reality.
Comment 1 Marcel Bruch CLA 2014-10-09 07:11:28 EDT
Moving to JDT core for comments.
Comment 2 Markus Keller CLA 2014-10-29 13:38:50 EDT
It's hard to tell what's going on here without steps to reproduce.

CompositeChange.perform(CompositeChange.java:323) tells that another exception occurred, but that's overridden by the AFE that happens in error-handling code.

The AFE is due to an invalid implementation of 
org.eclipse.ltk.core.refactoring.Change#perform(IProgressMonitor)
that returns a Change object that already is already part of another change. E.g. returns 'this'.
Comment 3 Mauro Molinari CLA 2015-08-27 05:23:55 EDT
I just submitted this: https://dev.eclipse.org/recommenders/community/confess/#/incidents/JBjboDiRBmcyD5iGDXNzt5tde8SKDIYNIrntlrhTAuNFpkMHt0QWhKl5YJ8we50K

In my case, this happened when I tried to preview a refactoring (class move from one package to another).
Steps to repro were approximately these:
- drag the class from the old package to the new one
- checked "Update fully qualified names in non-Java text files" (pattern *)
- hit preview,
- hit back
- unchecked "Update fully qualified names in non-Java text files"
- hit preview

Just tried another time doing exactly this and it seems like I got the exception once again.
Comment 4 Mauro Molinari CLA 2018-02-08 03:13:09 EST
Still seeing it in Oxygen.2 when previewing a class move from one package to another.
Comment 5 Eclipse Genie CLA 2020-05-27 16:31:05 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 6 Eclipse Genie CLA 2022-05-24 11:53:40 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.