Bug 443883 - [site_login] Password change should invalidate all active sessions
Summary: [site_login] Password change should invalidate all active sessions
Status: RESOLVED FIXED
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: Website (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: phoenix.ui CLA
QA Contact:
URL:
Whiteboard:
Keywords: security
: 453778 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-09-11 18:13 EDT by TANUJ JANE CLA
Modified: 2015-05-06 10:37 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description TANUJ JANE CLA 2014-09-11 18:13:24 EDT
Vulnerability- All Active Session Not Expire Automatically After Changing Password

Vulnerability description- 

When password is changed, not all active session expire automatically.
* Industry Standard Procedure
when the password is changed has been updated for any particular account, all the sessions which were active with the old password should be destroyed.

* Reason
if somehow anybody hacked into your account and you understand that someone has trespassed into your account, then what will you do? You will change your password to secure your account. But in www.eclipse.org changing the password does not destroys the other sessions which are logged in with old passwords. So, your account remains insecure even after the changing of password.

Login with same www.westernunion.com account in two different browser.
And try to change the password in anyone browser.
And notice in 2nd browser that session not expire.
Comment 1 Denis Roy CLA 2014-10-02 08:37:29 EDT
Agreed.
Comment 2 Christopher Guindon CLA 2014-12-08 12:19:39 EST
*** Bug 453778 has been marked as a duplicate of this bug. ***
Comment 3 TANUJ JANE CLA 2014-12-11 13:48:51 EST
My bug is 443883 and you were tag it duplicate of 453778. 
How it is possible ?
Comment 4 Christopher Guindon CLA 2014-12-11 13:52:25 EST
(In reply to TANUJ JANE from comment #3)
> My bug is 443883 and you were tag it duplicate of 453778. 
> How it is possible ?

Bug 453778 is a duplicate of your bug. Someone else created a bug about this after you.
Comment 5 TANUJ JANE CLA 2014-12-11 13:56:14 EST
(In reply to Christopher Guindon from comment #4)
> (In reply to TANUJ JANE from comment #3)
> > My bug is 443883 and you were tag it duplicate of 453778. 
> > How it is possible ?
> 
> Bug 453778 is a duplicate of your bug. Someone else created a bug about this
> after you.

Hello, My id is 443883
Comment 6 TANUJ JANE CLA 2015-01-09 16:01:04 EST
Hello,
Thwn who will get the credit of this bug ?
Any Hall Of Fame or bounty ?
Comment 7 TANUJ JANE CLA 2015-01-09 16:04:59 EST
(In reply to Denis Roy from comment #1)
> Agreed.

Hello,
Thwn who will get the credit of this bug ?
Any Hall Of Fame or bounty ?
Comment 8 Christopher Guindon CLA 2015-01-12 15:23:13 EST
(In reply to TANUJ JANE from comment #7)
> (In reply to Denis Roy from comment #1)
> > Agreed.
> 
> Hello,
> Thwn who will get the credit of this bug ?
> Any Hall Of Fame or bounty ?

This should be fixed when we roll out the new site_login website:

https://git.eclipse.org/c/websites/dev.eclipse.org.git/commit/?id=875a68e987ac2c6e1f43c9345627b8196cc2e5fe&context=3&ignorews=0&ss=0


If the user clicks on the e-mail link to reset his password, we will destroy all existing sessions for your user.
Comment 9 Christopher Guindon CLA 2015-01-19 16:21:43 EST
This is now live, closing this bug.

thanks
Comment 10 TANUJ JANE CLA 2015-01-19 16:30:34 EST
(In reply to Christopher Guindon from comment #9)
> This is now live, closing this bug.
> 
> thanks

Hello Christopher,
Any HOF ?
Comment 11 Christopher Guindon CLA 2015-01-19 16:37:36 EST
(In reply to TANUJ JANE from comment #10)
> (In reply to Christopher Guindon from comment #9)
> > This is now live, closing this bug.
> > 
> > thanks
> 
> Hello Christopher,
> Any HOF ?

We are currently looking for a low-maintenance way of creating and maintaining an Hall of Fame page.

Feel free to help us out on this bug:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=421105
Comment 12 TANUJ JANE CLA 2015-01-19 16:45:05 EST
(In reply to Christopher Guindon from comment #11)
> (In reply to TANUJ JANE from comment #10)
> > (In reply to Christopher Guindon from comment #9)
> > > This is now live, closing this bug.
> > > 
> > > thanks
> > 
> > Hello Christopher,
> > Any HOF ?
> 
> We are currently looking for a low-maintenance way of creating and
> maintaining an Hall of Fame page.
> 
> Feel free to help us out on this bug:
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=421105

 Hello Christopher,
Any bounty ?
Comment 13 Christopher Guindon CLA 2015-01-20 09:52:15 EST
(In reply to TANUJ JANE from comment #12)
> (In reply to Christopher Guindon from comment #11)
> > (In reply to TANUJ JANE from comment #10)
> > > (In reply to Christopher Guindon from comment #9)
> > > > This is now live, closing this bug.
> > > > 
> > > > thanks
> > > 
> > > Hello Christopher,
> > > Any HOF ?
> > 
> > We are currently looking for a low-maintenance way of creating and
> > maintaining an Hall of Fame page.
> > 
> > Feel free to help us out on this bug:
> > https://bugs.eclipse.org/bugs/show_bug.cgi?id=421105
> 
>  Hello Christopher,
> Any bounty ?

We currently don't have a bounty program but we are currently working on a HOF page.
Comment 14 Denis Roy CLA 2015-05-04 11:47:00 EDT
Another researcher is claiming that this is not working as expected; ie, even after changing passwords, some sessions remain active and usable.  Looking at the patch in comment 8, I suspect some of it may be related to our usage of a Bugzilla ID.
Comment 15 Christopher Guindon CLA 2015-05-04 14:42:25 EDT
(In reply to Denis Roy from comment #14)
> Another researcher is claiming that this is not working as expected; ie,
> even after changing passwords, some sessions remain active and usable. 
> Looking at the patch in comment 8, I suspect some of it may be related to
> our usage of a Bugzilla ID.

This works fine if the user use the "forgot my password" page. 

We should discuss if we should destroy all the session for the user if they change their password from their my account page.

What we can do here is:

If the user is changing his password under his my account page, we can destroy all the sessions and ask him to login again.

Also, since we are here. I am thinking that we should destroy all sessions for a user if they decide to logout. Currently, we are only destroying the session that the user is currently using.
Comment 16 Denis Roy CLA 2015-05-04 14:51:26 EDT
> We should discuss if we should destroy all the session for the user if they
> change their password from their my account page.

I initially was against destroy perfectly valid sessions because you simply decide to change your password.  But the use-case that this researcher named was, if a user suspects that their account credentials may have leaked -- they'd want to change their password to ensure no one else can access their account.

> What we can do here is:
> 
> If the user is changing his password under his my account page, we can
> destroy all the sessions and ask him to login again.

+1 that doesn't seem to be unreasonable.  And at the same time, the user can test their new password to make sure it in fact works.


 
> Also, since we are here. I am thinking that we should destroy all sessions
> for a user if they decide to logout. Currently, we are only destroying the
> session that the user is currently using.

+1
Comment 17 Eclipse Genie CLA 2015-05-04 16:20:59 EDT
New Gerrit change created: https://git.eclipse.org/r/47093
Comment 19 Denis Roy CLA 2015-05-06 10:08:33 EDT
Chris, I've pulled in the changes to dev.eclipse.org if you'd like to sanity check.
Comment 20 Christopher Guindon CLA 2015-05-06 10:23:25 EDT
(In reply to Denis Roy from comment #19)
> Chris, I've pulled in the changes to dev.eclipse.org if you'd like to sanity
> check.

I found a small bug, can you pull in the changes again? thanks

https://git.eclipse.org/c/websites/dev.eclipse.org.git/commit/?id=41652843916dbabce2cd5fdcb627b816496880fc
Comment 21 Denis Roy CLA 2015-05-06 10:30:55 EDT
Done
Comment 22 Christopher Guindon CLA 2015-05-06 10:37:44 EDT
(In reply to Denis Roy from comment #21)
> Done

Everything is working now! A password change will delete all sessions associated with the user.

thanks